Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PyPy #4281

Merged
merged 7 commits into from
Jan 3, 2021
Merged

Add PyPy #4281

merged 7 commits into from
Jan 3, 2021

Conversation

fbernhart
Copy link
Contributor

pypy

Closes #2963
Alexa rank: #325,854

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Source: https://www.pypy.org/images/pypy-logo.svg
Color: #193440 as this is the color of the letters "pypy" in the logo. If anyone has a better idea for a color, let me know!

Note: As discussed in #2963 it was necessary to create the gaps to maintain the style of the original logo.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Dec 6, 2020
@fbernhart fbernhart mentioned this pull request Dec 8, 2020
Closed
@fbernhart
Copy link
Contributor Author

I've now decreased the gap width to 0.35 px. In my opinion it looks even better now.

pypy

@fbernhart fbernhart marked this pull request as ready for review December 15, 2020 22:57
adamrusted
adamrusted requested changes Dec 27, 2020
View reviewed changes
icons/pypy.svg Outdated
@@ -0,0 +1 @@
<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>PyPy icon</title><path d="M12.645.015a2.7 2.7 0 0 0-1.278.456c-.125.006-.247.026-.37.037-1.838.257-3.128 1.184-4.028 2.294-1.69 2.497-1.711 6.045-1.487 8.424a6.64 6.64 0 0 1 2.315-4.14l.057-.04a8.72 8.72 0 0 1 .435-.325c.028-.014.056-.027.084-.055.155-.098.295-.183.45-.281l.083-.043c.155-.085.31-.155.479-.225.028-.014.07-.029.097-.043.127-.056.269-.097.395-.139a2.186 2.186 0 0 0-.268-.24 1.823 1.823 0 0 0-.73-.266 2.37 2.37 0 0 0-.342-.04c-.023 0-.045-.006-.068-.007a4.648 4.648 0 0 0-.42.004h-.014a4.354 4.354 0 0 0-.818.123c.264-.11.527-.208.818-.264a3.78 3.78 0 0 1 .871-.111h.008c.087 0 .178.013.268.021.06.006.12.004.181.014l.004.002c.153.026.307.068.453.13.24.1.45.267.633.464.004 0 .007 0 .01-.002l.004.002a2.819 2.819 0 0 0 2.416.956l.254-.041h.041l.566-.116c1.853-.431 2.176-.506 3.123-1.033.4-.322.562-.549.631-.763.07-.217.055-.455.072-.797l-.002.01c-.001-.374-.281-.799-.695-1.22-.41-.417-.932-.824-1.365-1.196-.53-.374-.785-.718-1.031-.973a1.644 1.644 0 0 0-.678-.456l-.004-.002c-.004 0-.008 0-.012-.002a2.789 2.789 0 0 0-1.138-.117zm2.705.956c.11.101.205.2.359.309l.008.004.006.005c.424.366.962.78 1.4 1.226.438.446.795.93.797 1.466v.004l-.002.006c-.016.318.008.588-.088.885-.096.297-.31.588-.754.94l-.012.01-.011.008a9.766 9.766 0 0 1-.584.302c1.23.486 2.465 1.072 3.806 2.12v-.003c1.192.924 2.313 2.026 3.442 3.67C23.582 6.736 20.1 2.403 15.35.972zM8.533.983A11.619 11.619 0 0 0 3.71 3.88a11.635 11.635 0 0 0-3.426 8.183c.042 1.823.678 3.187 1.682 4.189 1.048 1.046 2.5 1.7 4.08 2.032 1.586.333 3.25.44 4.748.358a6.612 6.612 0 0 1-5.121-4.603l-.006-.017c-.014-.049-.03-.096-.043-.145-.06-.176-.222-.681-.402-1.806v-.006c-.3-2.348-.525-6.538 1.463-9.469l.004-.006.003-.006A6.817 6.817 0 0 1 8.533.983zm4.955 3.854c.123.01.238.034.342.066h.002c.208.065.37.17.453.291.04.06.062.126.059.192-.014.124-.12.229-.28.303a1.242 1.242 0 0 1-.359.092 1.6 1.6 0 0 1-.287.013c-.492-.042-.871-.282-.857-.549a.287.287 0 0 1 .074-.162.425.425 0 0 1 .043-.043c.024-.022.057-.041.088-.06a1 1 0 0 1 .334-.126l.007-.002a1.49 1.49 0 0 1 .381-.015zm2.516 1.487c-.166.062-.46.143-.668.201 1.749 1.036 2.984 2.844 3.2 4.972h.007l.006.131c.006.072.022.14.025.212.014.126.014.252.014.392 0 .022-.004.043-.004.065.08 2.26-.298 3.507-1.309 5.613v.002c-.988 2.091-3.234 4.628-5.007 6.088 6.245-.157 11.277-5.186 11.447-11.445-1.205-1.864-2.381-3.037-3.654-4.024-1.43-1.117-2.725-1.7-4.057-2.207zm2.103 8.254c-.045.119-.086.24-.138.355-.028.057-.056.126-.084.182a6.537 6.537 0 0 1-1.461 1.927l-.295.252c-.14.113-.295.226-.45.338a5.127 5.127 0 0 1-.548.323 6.6 6.6 0 0 1-1.084.457c-2.017.713-5.155.83-8.074.217-1.629-.342-3.145-1.019-4.256-2.128A5.899 5.899 0 0 1 .54 14.812c1.156 5.168 5.69 9.04 11.168 9.178 1.757-1.355 4.24-4.09 5.25-6.229v-.002c.604-1.258.967-2.173 1.148-3.181z"/></svg>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing some small differences between PR (red) and source (black), while the segments are spot on - the path is slightly out of shape. Could be optimization, but would you mind taking a look?

image

Copy link
Contributor Author

@fbernhart fbernhart Dec 29, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamrusted Thanks for pointing this out! I gave it another try and it should be a lot better now.

Note: It might not fit the source up to 100%. Because the gap at the bottom is "cutting off" the edge at the bottom slightly. So the icon was 23,988px after cutting out the gaps and I had to resize it again to 24px.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth holding off on this until #4530 reaches a conclusion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamrusted Sure 👍🏼

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamrusted Can we merge this one now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly can! 🎉

@adamrusted adamrusted added in discussion There is an ongoing discussion that should be finished before we can continue and removed changes requested labels Dec 29, 2020
@adamrusted adamrusted merged commit d60a764 into simple-icons:develop Jan 3, 2021
@adamrusted adamrusted removed the in discussion There is an ongoing discussion that should be finished before we can continue label Jan 3, 2021
@fbernhart fbernhart deleted the PyPy branch January 3, 2021 17:31
@github-actions github-actions bot mentioned this pull request Jan 10, 2021
Merged
ericcornelissen added a commit that referenced this pull request Jan 10, 2021
@ericcornelissen
Release 103 new icons and 41 updated icons (v4.6.0)
701d605 
# New Icons

- 3M (#3631)
- Accenture (#4396)
- AIOHTTP (#4536)
- AniList (#4609)
- AnyDesk (#4663)
- Apache JMeter (#4594)
- Apache Kylin (#4545)
- ARK Ecosystem (#4699)
- B&amp;R Automation (#4552)
- bigbasket (#4572, #4616)
- Bugcrowd (#4615)
- CheckiO (#4512)
- Chrysler (#4357)
- Cloudways (#3352)
- Cockroach Labs (#4665)
- CodeProject (#4617)
- CodinGame (#4575)
- Cognizant (#4392)
- Contentful (#4537)
- Cookiecutter (#3649)
- DataStax (#4393)
- De'Longhi (#4426)
- Deepnote (#4546)
- Digi-Key Electronics (#4398)
- Eclipse Vert.x (#4631)
- edX (#4452)
- egghead (#4644)
- Eight Sleep (#3638)
- Facepunch (#3671)
- FedEx (#4564)
- Fortran (#4397)
- FreeNAS (#4573)
- Gitee (#4625)
- Google Domains (#4622)
- Google Photos (#4341)
- Grubhub (#4544)
- Homebridge (#4607)
- Hyperledger (#4673)
- IKEA (#4555)
- Ingress (#3389)
- Jitsi (#4540)
- Kitsu (#4520)
- Klook (#4548)
- Lada (#4361)
- Lichess (#3535)
- Linktree (#4662)
- Looker (#4442)
- McLaren (#4538)
- MetaFilter (#4547)
- Motorola (#3425)
- Noun Project (#4608)
- Observable (#4640)
- Open Bug Bounty (#4627)
- Open Nebula (#4551)
- OpenCV (#4580)
- PageSpeed Insights (#4553)
- Paytm (#4643)
- pfSense (#4671)
- Pop!_OS (#3769)
- Progate (#3680)
- Progress (#4611)
- PyPy (#4281)
- Racket (#3483)
- Radar (#4319)
- Rainmeter (#3554)
- Reliance Industries Limited (#4702)
- Revue (#4391)
- ROS (#4658)
- SciPy (#3772)
- Scrimba (#4556)
- SEPA (#3154)
- SoloLearn (#4624)
- Spark AR (#4468)
- Speedtest (#4626)
- STARZ (#4612)
- Streamlit (#4412)
- Swiper (#4562)
- São Paulo Metro (#4570)
- tado° (#4637)
- TaxBuzz (#4619)
- Testin (#4571)
- Testing Library (#4542)
- ThinkPad (#4550)
- Ticketmaster (#4526)
- Tile (#4614)
- tmux (#3512)
- Treyarch (#4690)
- TrueNAS (#4574)
- Unraid (#4613)
- UPS (#4565)
- USPS (#4549)
- Vault (#4606)
- Vimeo Livestream (#4703)
- Webflow (#4568)
- Weights &amp; Biases (#4630)
- Wikiquote (#4687)
- Winmate (#3316)
- Wipro (#4359)
- Xilinx (#3424)
- Zelle (#4605)
- Zoho (#3661)
- Zomato (#4664)
- Zotero (#4561)

# Updated Icons

- Adobe XD (#3386)
- Amazon Lumberyard (#4591)
- Andela (#4592)
- Apache Maven (#4593)
- Daimler (#4618)
- DigitalOcean (#4648)
- Fossa (#4473)
- Gatsby (#4620)
- GIPHY (#4621)
- Google (#4508)
- Google Analytics (#4504)
- Google Cardboard (#4058)
- Google Fit (#4506)
- Harbor (#4598)
- Jira Software (#4657)
- Kahoot! (#4635)
- Kotlin (#4485)
- Kyocera (#4475)
- Lenovo (#4477)
- Material Design Icons (#4642)
- Mozilla (#4656)
- pr.co (#4655)
- SonicWall (#4654)
- StackPath (#4652)
- Stadia (#4503)
- Synology (#4220)
- TED (#4653)
- Trustpilot (#4481)
- Uber (#4650)
- Uber Eats (#4651)
- Udacity (#4596)
- Viber (#4597)
- Waze (#4583)
- Wish (#4482)
- WP Engine (#4639)
- XMPP (#4483)
- YouTube (#4582)
- YouTube Studio (#4581)
- YouTube TV (#4405)
- Zendesk (#4595)
- Zillow (#4636)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: PyPy
2 participants
@fbernhart @adamrusted