Add AR mixins to simple oauth2 #1

defvova · 2018-02-04T11:16:36Z

No description provided.

houndci-bot · 2018-02-04T11:28:30Z

spec/support/db/schema.rb

+#
+# It's strongly recommended that you check this file into your version control system.
+
+ActiveRecord::Schema.define(version: 20_180_203_210_135) do


Block has too many lines. [46/25]

houndci-bot · 2018-02-04T11:28:30Z

spec/support/db/migrations/20180203210135_create_schema.rb

@@ -0,0 +1,47 @@
+class CreateSchema < ActiveRecord::Migration[5.1]
+  def change


Assignment Branch Condition size for change is too high. [28/15]
Method has too many lines. [32/15]

houndci-bot · 2018-02-04T11:28:31Z

spec/mixins/resource_owner_spec.rb

@@ -0,0 +1,41 @@
+require 'spec_helper'
+
+describe User do


Block has too many lines. [27/25]

houndci-bot · 2018-02-04T11:28:31Z

spec/mixins/client_spec.rb

@@ -0,0 +1,77 @@
+require 'spec_helper'
+
+describe Client do


Block has too many lines. [54/25]

houndci-bot · 2018-02-04T11:28:31Z

spec/mixins/access_token_spec.rb

@@ -0,0 +1,137 @@
+require 'spec_helper'
+
+describe AccessToken do


Block has too many lines. [94/25]

houndci-bot · 2018-02-04T11:28:31Z

spec/mixins/access_grant_spec.rb

@@ -0,0 +1,74 @@
+require 'spec_helper'
+
+describe AccessGrant do


Block has too many lines. [51/25]

houndci-bot · 2018-02-04T11:28:31Z

lib/activerecord_simple_oauth2/mixins/resource_owner.rb

+          #
+          def self.oauth_authenticate(_client, username, password)
+            user = where(username: username.to_s).first
+            user if user && user.encrypted_password == password


Use safe navigation (&.) instead of checking if an object exists before calling the method.

houndci-bot · 2018-02-04T13:35:37Z

db/schema.rb

+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false
+  end
+


Extra empty line detected at block body end.

houndci-bot · 2018-02-04T13:35:37Z

db/schema.rb

+    t.string "username", null: false
+    t.string "encrypted_password", null: false
+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-02-04T13:35:37Z

db/schema.rb

+  create_table "users", force: :cascade do |t|
+    t.string "username", null: false
+    t.string "encrypted_password", null: false
+    t.datetime "created_at", null: false


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-02-04T13:35:37Z

db/schema.rb

+
+  create_table "users", force: :cascade do |t|
+    t.string "username", null: false
+    t.string "encrypted_password", null: false


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-02-04T13:35:37Z

db/schema.rb

+  end
+
+  create_table "users", force: :cascade do |t|
+    t.string "username", null: false


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-02-04T13:35:37Z

db/schema.rb

+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false
+    t.index ["key"], name: "index_applications_on_key"
+    t.index ["secret"], name: "index_applications_on_secret"


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-02-04T13:35:37Z

db/schema.rb

+    t.string "secret", null: false
+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false
+    t.index ["key"], name: "index_applications_on_key"


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-02-04T13:35:38Z

db/schema.rb

+    t.string "key", null: false
+    t.string "secret", null: false
+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-02-04T13:35:38Z

db/schema.rb

+    t.string "redirect_uri", null: false
+    t.string "key", null: false
+    t.string "secret", null: false
+    t.datetime "created_at", null: false


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-02-04T13:35:38Z

db/schema.rb

+    t.string "name", null: false
+    t.string "redirect_uri", null: false
+    t.string "key", null: false
+    t.string "secret", null: false


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-02-04T13:45:50Z

db/schema.rb

+  create_table "applications", force: :cascade do |t|
+    t.string "name", null: false
+    t.string "redirect_uri", null: false
+    t.string "key", null: false


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-02-04T15:33:48Z

db/schema.rb

+    t.datetime "created_at",         null: false
+    t.datetime "updated_at",         null: false
+  end
+


Extra empty line detected at block body end.

houndci-bot · 2018-02-04T15:33:48Z

db/schema.rb

+    t.string   "username",           null: false
+    t.string   "encrypted_password", null: false
+    t.datetime "created_at",         null: false
+    t.datetime "updated_at",         null: false


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-02-04T15:33:48Z

db/schema.rb

+  end
+
+  add_index "clients", ["key"], name: "index_clients_on_key"
+  add_index "clients", ["secret"], name: "index_clients_on_secret"


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-02-04T15:33:48Z

db/schema.rb

+    t.datetime "updated_at",   null: false
+  end
+
+  add_index "clients", ["key"], name: "index_clients_on_key"


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-02-04T16:15:08Z

db/migrations/20180204143133_create_schema.rb

@@ -0,0 +1,47 @@
+class CreateSchema < ActiveRecord::Migration[5.0]
+  def change


Assignment Branch Condition size for change is too high. [28/15]
Method has too many lines. [32/15]

houndci-bot · 2018-02-04T16:15:08Z

db/migrations/20180204143133_create_schema.rb

@@ -0,0 +1,47 @@
+class CreateSchema < ActiveRecord::Migration[5.0]


Missing top-level class documentation comment.

defvova force-pushed the add_ar_simple_oauth2 branch from 7112cb6 to c78025d Compare February 4, 2018 11:21

simple-oauth2 deleted a comment from houndci-bot Feb 4, 2018

defvova force-pushed the add_ar_simple_oauth2 branch from c78025d to 3e17f18 Compare February 4, 2018 11:28

houndci-bot reviewed Feb 4, 2018

View reviewed changes

defvova force-pushed the add_ar_simple_oauth2 branch 2 times, most recently from 67158bb to 8753810 Compare February 4, 2018 13:35

houndci-bot reviewed Feb 4, 2018

View reviewed changes

defvova force-pushed the add_ar_simple_oauth2 branch from 8753810 to f5aeb4e Compare February 4, 2018 13:45

houndci-bot reviewed Feb 4, 2018

View reviewed changes

defvova force-pushed the add_ar_simple_oauth2 branch 2 times, most recently from c7e4e1d to a9bd685 Compare February 4, 2018 15:33

houndci-bot reviewed Feb 4, 2018

View reviewed changes

defvova force-pushed the add_ar_simple_oauth2 branch 4 times, most recently from 320da39 to 6656fb3 Compare February 4, 2018 16:14

houndci-bot reviewed Feb 4, 2018

View reviewed changes

defvova force-pushed the add_ar_simple_oauth2 branch 9 times, most recently from 413edd6 to 6b893e0 Compare February 4, 2018 20:59

Add AR mixins to simple oauth2

80d9aaa

defvova force-pushed the add_ar_simple_oauth2 branch from 6b893e0 to 80d9aaa Compare February 4, 2018 21:08

defvova merged commit 0e47ac0 into master Feb 17, 2018

defvova deleted the add_ar_simple_oauth2 branch February 17, 2018 10:39

		@@ -0,0 +1,47 @@
		class CreateSchema < ActiveRecord::Migration[5.1]
		def change

		@@ -0,0 +1,137 @@
		require 'spec_helper'

		describe AccessToken do

		@@ -0,0 +1,74 @@
		require 'spec_helper'

		describe AccessGrant do

Add AR mixins to simple oauth2 #1

Add AR mixins to simple oauth2 #1

Uh oh!

Conversation

defvova commented Feb 4, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants