core: signed messages status#6699
Merged
epoberezkin merged 6 commits intochat-relaysfrom Mar 24, 2026
Merged
Conversation
evgeny-simplex
force-pushed
the
ep/signed-msgs
branch
6 times, most recently
from
c8d5175 to
4bf48f1
Compare
evgeny-simplex
force-pushed
the
ep/signed-msgs
branch
from
4bf48f1 to
6efca97
Compare
epoberezkin
commented
Mar 23, 2026
epoberezkin
commented
Mar 23, 2026
Co-authored-by: Evgeny <evgeny@poberezkin.com>
evgeny-simplex
force-pushed
the
ep/signed-msgs
branch
from
59aedc3 to
44e501c
Compare
spaced4ndy
reviewed
Mar 24, 2026
|
|
||
| $(JQ.deriveJSON (enumJSON $ dropPrefix "RS") ''RelayStatus) | ||
|
|
||
| data MsgSigStatus = MSSVerified | MSSSignedNoKey |
Contributor
There was a problem hiding this comment.
Suggested change
| data MsgSigStatus = MSSVerified | MSSSignedNoKey | |
| data MsgSigStatus = MSSVerified | MSSSignatureUnverified |
spaced4ndy
reviewed
Mar 24, 2026
Comment on lines
+120
to
+123
| MSSSignedNoKey -> "no_key" | ||
| textDecode = \case | ||
| "verified" -> Just MSSVerified | ||
| "no_key" -> Just MSSSignedNoKey |
Contributor
There was a problem hiding this comment.
Suggested change
| MSSSignedNoKey -> "no_key" | |
| textDecode = \case | |
| "verified" -> Just MSSVerified | |
| "no_key" -> Just MSSSignedNoKey | |
| MSSSignatureUnverified -> "signature_unverified" | |
| textDecode = \case | |
| "verified" -> Just MSSVerified | |
| "signature_unverified" -> Just MSSSignatureUnverified |
spaced4ndy
reviewed
Mar 24, 2026
| sigStatusStr :: IsString a => Maybe MsgSigStatus -> a | ||
| sigStatusStr = \case | ||
| Just MSSVerified -> " (signed)" | ||
| Just MSSSignedNoKey -> " (signed, no key to verify)" |
Contributor
There was a problem hiding this comment.
"signed, no key to verify" implies client has knowledge it was signed by sender, even though without verification it can be completely made up by relay, not really "signed".
Suggested change
| Just MSSSignedNoKey -> " (signed, no key to verify)" | |
| Just MSSSignedNoKey -> " (signature unverified)" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.