-
-
Notifications
You must be signed in to change notification settings - Fork 43
Added printable type (random printable ascii chars) #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
What does “printable characters” refer to exactly? And what’s the use-case? |
|
Printable chars are characters that can be displayed, you can read more here: https://en.wikipedia.org/wiki/ASCII#ASCII_printable_characters They are used during the generation of a random password (password recovery for example), where it is necessary to generate and email a password with printable characters. When generating a password it is good practice to use all possible characters and not restrict to "a-zA-Z0-9!$%&@#", since it is saved (and compared) as a hash it is not necessary to filter the chars to be "safe". |
|
Should be You also need to update the readme and the TypeScript definition. |
|
@stroncium Thoughts on this? |
|
+1 on -1 on general idea:
So, if we were to introduce something to generate full random passwords, we might just go for it and make a good generator, not the most primitive thing. @ZeroBug-ZB |
|
@ZeroBug-ZB Can you rename it to @stroncium I agree with you. I still think this mode could be useful for other things though. After merging this PR, maybe you could submit a PR to recommend https://github.com/stroncium/node-xkcdpass for generating passwords. |
|
@ZeroBug-ZB Bump |
No description provided.