-
-
Notifications
You must be signed in to change notification settings - Fork 150
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Current behaviour
When I set 'keymaps.disable_defaults = true' all default bindings are still created and available:
require("diffview").setup({
keymaps = {
disable_defaults = true,
}
})
All keybindings are still shown and available:

When I disable a binding explicitly it works as expected:
require("diffview").setup({
keymaps = {
view = {
{ "n", "]x", false },
},
},
})
The disabled binding is not shown and not available:

Expected behaviour
I expect when I set 'keymaps.disable_defaults = true' that no bindings are set by default and therefore the list of available key-bindings to be empty. This should have the same effect as setting the value 'false' on each keymap individually.
Version nvim
❯ nvim -v
NVIM v0.8.1
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3
Compilation: /usr/bin/gcc-10 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DNVIM_TS_HAS_SET_MATCH_LIMIT -DNVIM_TS_HAS_SET_ALLOCATOR -O2 -g -Og -g -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wdouble-promotion -Wmissing-noreturn -Wmissing-format-attribute -Wmissing-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fno-common -fdiagnostics-color=always -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -DMIN_LOG_LEVEL=3 -I/__w/neovim/neovim/build/cmake.config -I/__w/neovim/neovim/src -I/__w/neovim/neovim/.deps/usr/include -I/usr/include -I/__w/neovim/neovim/build/src/nvim/auto -I/__w/neovim/neovim/build/include
Compiled by root@08a8cca64bea
Features: +acl +iconv +tui
See ":help feature-compile"
system vimrc file: "$VIM/sysinit.vim"
fall-back for $VIM: "/__w/neovim/neovim/build/nvim.AppDir/usr/share/nvim"
Run :checkhealth for more info
Version diffview
❯ glog -1
* aeca096 (grafted, HEAD -> main, origin/main, origin/HEAD) fix: Regression in buffer creation for renamed files.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working