-
-
Notifications
You must be signed in to change notification settings - Fork 150
feat(help): Help panel popup #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR! I see that you're using the Nui library here. I would like to avoid relying on additional dependencies. Especially for something as simple as creating a buffer in a floating window. That, and we already have a Panel abstraction that allows us to do this quite easily. For an example, see i.e. the commit log panel. The way you have changed the structure of the keymap declerations in the config will unnecessarily break compatibility with vim command maps. Also, please do not format parts of the code that you didn't touch. It makes it harder to review the changes. Let me know if you have any questions about implementation :) |
|
@sindrets Thanks for your review. I rewrote by your comment. I tried to create runnable command in list, but I didn't. Before ready for merge I want to complete this feature. Can you give me a tip how to run command for current panel(not help panel), if you know ? If you think this feature is overrate, I will remove it. |
I don't understand what that is. Can you please elaborate? |
|
@sindrets It's like. I have menu -> press "enter" -> command under cursor would be apply. |
|
I did it, Please review) |
sindrets
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I refactored it a little bit.
|
Awesome! This is fantastic |
|
This is awesome, but will it be possible to add a little annotation at the top of the window about how to open the help pane? I think it is not obvious for everybody. |

Resolves #168.
Hello, I tried add desc and popup menu for keymaps.