-
Notifications
You must be signed in to change notification settings - Fork 0
Fix of db_functions tests #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4983124 to
59c3163
Compare
| authors = Author.objects.annotate(joined=Concat("alias", "goes_by")) | ||
| #In Singlestore , If any of the arguments is NULL, the result is NULL in CONCAT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add as_singlestore to the class ConcatPair(Func):, see as_mysql there, it should work.
| models.PositiveBigIntegerField, | ||
| models.PositiveIntegerField, | ||
| models.PositiveSmallIntegerField, | ||
| ): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why these are removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Casting to unsigned int was failing. I'll double-check the issue and share more details on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sql query generating for these look like
'SELECT db_functions_author.id, db_functions_author.name, db_functions_author.alias, db_functions_author.goes_by, db_functions_author.age, (db_functions_author.alias) :> UNSIGNED BIGINT AS cast_int FROM db_functions_author'
ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ' UNSIGNED BIGINT AS cast_int FROM db_functions_author'
3c1960e to
b53475d
Compare
b53475d to
fe14521
Compare
No description provided.