Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/_utils/local_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ export DJANGO_SINGLESTORE_TABLE_STORAGE_TYPE_MANY_TO_MANY="ROWSTORE REFERENCE"
# a number of models with unique keys, 13 many-to-many fields
export DJANGO_SINGLESTORE_TABLE_STORAGE_TYPE_FIXTURES_REGRESS="ROWSTORE REFERENCE"

# a model with 3 many-to-many fields caused issues
export DJANGO_SINGLESTORE_TABLE_STORAGE_TYPE_DELETE="ROWSTORE REFERENCE"


# queries app has a lot of models with OneToOne relationships
export DJANGO_SINGLESTORE_NOT_ENFORCED_UNIQUE_QUERIES=1

Expand Down
10 changes: 10 additions & 0 deletions tests/_utils/setup.sql
Original file line number Diff line number Diff line change
Expand Up @@ -590,3 +590,13 @@ CREATE TABLE `backends_object_object` (
KEY (`from_object_id`),
KEY (`to_object_id`)
);

-- delete
CREATE TABLE `delete_player_game` (
`player_id` BIGINT NOT NULL,
`game_id` BIGINT NOT NULL,
SHARD KEY (`player_id`),
UNIQUE KEY (`player_id`, `game_id`),
KEY (`player_id`),
KEY(`game_id`)
);
25 changes: 25 additions & 0 deletions tests/delete/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
from django.contrib.contenttypes.models import ContentType
from django.db import models

from django_singlestore.schema import ModelStorageManager


class P(models.Model):
pass
Expand Down Expand Up @@ -241,3 +243,26 @@ class GenericDeleteBottomParent(models.Model):
generic_delete_bottom = models.ForeignKey(
GenericDeleteBottom, on_delete=models.CASCADE
)


class Game(models.Model):
home = models.CharField(max_length=100)
away = models.CharField(max_length=100)

objects = ModelStorageManager("ROWSTORE")


class Player(models.Model):
name = models.CharField(max_length=100)
games = models.ManyToManyField(Game, related_name="players", through="PlayerGame")

objects = ModelStorageManager("ROWSTORE")


class PlayerGame(models.Model):
player = models.ForeignKey(Player, on_delete=models.CASCADE)
game = models.ForeignKey(Game, on_delete=models.CASCADE)

class Meta:
unique_together = (('player', 'game'),)
db_table = "delete_player_game"
16 changes: 16 additions & 0 deletions tests/delete/tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@
S,
T,
User,
Game,
Player,
create_a,
get_default_r,
)
Expand Down Expand Up @@ -800,3 +802,17 @@ def test_fast_delete_full_match(self):
with self.assertNumQueries(1):
User.objects.filter(~Q(pk__in=[]) | Q(avatar__desc="foo")).delete()
self.assertFalse(User.objects.exists())

def test_delete_with_custom_m2m(self):
"""
Test that deletion of a model with a custom through model
that doesn't have id field works correctly.
"""
g1 = Game.objects.create()
g2 = Game.objects.create()

player = Player.objects.create()
player.games.add(g1, g2)
g1.delete()
g2.delete()
self.assertFalse(Game.objects.exists())
Loading