Undefined variable flagged in consecutive lines

[paulschreiber]

I would expect to only see one error here:

16 <?php if ( $error ) : ?>
17 <code><?php echo esc_html( $error ); ?></code>
18 <?php endif; ?>

It's possible this is intentional. I wanted to flag it in case it was not. (This is a WordPress template-part; variables are defined in the parent.)

FILE: template-parts/mail-error.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------
 16 | WARNING | Variable $error is undefined.
    |         | (VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedVariable)
 17 | WARNING | Variable $error is undefined.
    |         | (VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedVariable)
-----------------------------------------------------------------------------------------------------------------

[sirbrillig]

It is intentional (they are both uses of an undefined variable). However, if you plan on scanning a lot of template files, you might want to ignore undefined variables in the file scope using the allowUndefinedVariablesInFileScope option, added in v3.0.0-beta.4.

[sirbrillig]

Probably worth mentioning that 3.0 final is just pending at least a beta release of phpcsutils. It's otherwise quite stable to use.