Update for phpcs 4.0.0 #356
Merged
+205
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirbrillig
force-pushed
the
phpcs-4.0
branch
from
19c4bf4 to
02d3d7f
Compare
sirbrillig
force-pushed
the
phpcs-4.0
branch
from
e0d6ace to
b4d100d
Compare
jrfnl
reviewed
Sep 30, 2025
|
Nearly got this working. There's just coverage failures now: |
No, you added PHPUnit 12 to the |
🤦 Oops! I just updated all the dependencies without looking too closely at major versions. Thank you! |
sirbrillig
force-pushed
the
phpcs-4.0
branch
from
f612edd to
067e988
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #355
This PR follows the upgrade guide in https://github.com/PHPCSStandards/PHP_CodeSniffer/wiki/Version-4.0-Developer-Upgrade-Guide
The main change is supporting the
T_NAME...constants likeT_NAME_FULLY_QUALIFIEDin function names.