Skip to content

Conversation

@bonnybun
Copy link

No description provided.

@sitatec sitatec self-requested a review November 21, 2022 13:21
@codecov-commenter
Copy link

Codecov Report

Merging #14 (bab8353) into main (172d87a) will decrease coverage by 15.82%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main      #14       +/-   ##
===========================================
- Coverage   96.87%   81.04%   -15.83%     
===========================================
  Files           5        5               
  Lines         128      153       +25     
===========================================
  Hits          124      124               
- Misses          4       29       +25     
Impacted Files Coverage Δ
lib/src/mock_data_snapshot.dart 26.47% <0.00%> (-73.53%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sitatec
Copy link
Owner

sitatec commented Nov 21, 2022

Hey @bonnybun, thanks a lot for the PR 👍.
Can you please write unit tests for the new methods?
If you want I will write them my self later and push my commit to this PR before merging it.

@bonnybun
Copy link
Author

Hi @sitatec,
yes I will write unit tests today.

@sitatec sitatec merged commit 525c683 into sitatec:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants