Use Decimal type for amount calculations in Level 1. #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents other rounding bugs and comparison errors caused by the inability of floats to store base 10 numbers precisely. Add a test to hack.py to demonstrate the rounding error from using float.
heiskr
approved these changes
Apr 3, 2023
Closed
bgalek
added a commit
to bgalek/secure-code-game-fork
that referenced
this pull request
May 30, 2025
Season 3 tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents other rounding bugs and comparison errors caused by the inability of floats to store base 10 numbers precisely.
Add a test to hack.py to demonstrate the rounding error from using float.
Why:
Existing solution does not resolve rounding errors and incorrect comparisons caused by using the
floattype for base 10 calculations.What's being changed:
Convert item amounts to
Decimal.Add test case to
hack.pyto demonstrate the comparison problem.Add explanation in
solution.pywith link to Python's Decimal documentation as well as examples from the Python interpreter.