Skip to content

Simplify and increase robustness of sorting #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Simplify and increase robustness of sorting #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions src/abstractdataset/dscol.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,17 +150,11 @@ end



Base.Sort.defalg(col::SubOrDSCol) = Base.Sort.defalg(__!(col))
function Base.sort!(col::SubOrDSCol; alg::Base.Sort.Algorithm=Base.Sort.defalg(col), lt=isless, by=identity, rev::Bool=false, order::Base.Order.Ordering=Base.Order.Forward)
sort!(__!(col), alg=alg, lt=lt, by=by, rev=rev, order=order)
function Base.sort!(col::SubOrDSCol; kws...)
sort!(__!(col); kws...)
_modified(_attributes(parent(col.ds)))
col.col ∈ index(parent(col.ds)).sortedcols && _reset_grouping_info!(parent(col.ds))
col
end
function Base.sort(col::SubOrDSCol; alg::Base.Sort.Algorithm=Base.Sort.defalg(col), lt=isless, by=identity, rev::Bool=false, order::Base.Order.Ordering=Base.Order.Forward)
sort(__!(col), alg=alg, lt=lt, by=by, rev=rev, order=order)
end

function Base.sortperm(col::SubOrDSCol; alg::Base.Sort.Algorithm=Base.Sort.DEFAULT_UNSTABLE, lt=isless, by=identity, rev::Bool=false, order::Base.Order.Ordering=Base.Order.Forward)
sortperm(__!(col), alg=alg, lt=lt, by=by, rev=rev, order=order)
end
Base.sort(col::SubOrDSCol; kws...) = sort(__!(col); kws...)
Base.sortperm(col::SubOrDSCol; kws...) = sortperm(__!(col); kws...)