Added timeout and open_timeout options to Web API.#135
Added timeout and open_timeout options to Web API.#135dblock merged 1 commit intoslack-ruby:masterfrom
Conversation
|
Are there any downsides to also increasing the default? |
|
Faraday doesn't default the value to anything, letting the underlying Net::HTTP library handle this. I am a little wary setting it to something, but maybe I can be convinced otherwise. |
|
Check out my note in README though. |
|
👍 This is definitely an improvement, thanks for fixing. One upside of a larger default is that if this extension is ever used in say an open-source chatbot (pagerbot) having a large problem would avoid per-bot hacks and troubles for some of the larger users who try to use the bot and fail to log in. It might be worthwhile to merge this, then reach out to some of the people having issues and figuring out if a larger but still sane baseline setting as a default would make sense. |
|
I agree, we can save a lot of people debugging. What value are you using @macobo? Also are you changing only |
|
Oh according to https://ruby-doc.org/stdlib-2.4.0/libdoc/net/http/rdoc/Net/HTTP.html both of these are 60 (!) seconds. |
|
Sadly I don't have access to a large organization to test with, sorry! |
Related to #134.