Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing user object member to type BlockAction #1910

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

GovernmentHack
Copy link
Contributor

Summary

Adds missing string type member to user object in BlockAction type. Fixes (issue 1909)[https://github.com//issues/1909]

Requirements (place an x in each [ ])

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @gapodaca-atlassian to sign the Salesforce Inc. Contributor License Agreement.

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific labels Jul 31, 2023
@seratch seratch added this to the 3.13.3 milestone Jul 31, 2023
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@filmaj
Copy link
Contributor

filmaj commented Aug 1, 2023

This PR was helpful but we need to go a bit farther: the name field should now be optional (based on the block_actions documentation, Home tabs might return block_action payloads with a name field). I also think the unit tests are failing due to this addition.

Will try to fix this up and send another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented cla:signed semver:patch TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants