Fixes failing tests: block_actions.user.name is optional#1916
Conversation
|
Very bizarre... unclear why I can't reproduce the lint failure locally. Using the same version of eslint, too... |
|
I'm iterating on this issue on my fork here. One thing I noticed running in debug mode locally and on GitHub CI is that the eslint-plugin-import on my machine is running 2.27.5 but 2.28.0 on GitHub CI.. maybe that's it? Gonna try.. yep that was it. Upgrading my Floating dependency versions are a curse! |
…till be present, e.g. in Home tab actions. Fix related test, too. Bumping eslint-plugin-import dependency, fixing up lint errors.
9c73ef9 to
054433d
Compare
Codecov Report
@@ Coverage Diff @@
## main #1916 +/- ##
=======================================
Coverage 82.18% 82.18%
=======================================
Files 18 18
Lines 1521 1521
Branches 436 436
=======================================
Hits 1250 1250
Misses 175 175
Partials 96 96
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This relates to #1910 :
block_actionspayloads can send both ausernameas well asnamefield, depending on where the action originates from.namewill be present if the action was sent from the Home tab. See the Examples on theblock_actionsdocumentation for details.This also fixes (well, hopefully! the CI will be the judge of that) the currently-failing tests on
main. On GitHub CI the build was failing because GitHub was using v2.28.0 of the eslint-import-plugin, whereas on my machine (where I could not reproduce it) was using v2.27.5.