Fix redis bench test #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a crash when processing redis-benchmark tests where full_result_path is None. The test execution and metrics collection complete successfully, but the file preservation step would fail. Changes: - Add null check before shutil.copy(full_result_path, dest_fpath) - Log warning message when result path is unavailable - Prevents TypeError: stat: path should be string, not NoneType Fixes issue observed in: - memtier_benchmark-nokeys-pubsub-mixed-100-channels test - Other redis-benchmark output conversion scenarios
Root cause: Multi-client tests were parsing aggregated JSON from stdout but never writing it to the expected output file. This caused: 1. full_result_path to remain None 2. Results not being preserved to aggregated results folder 3. Missing JSON files for multi-client tests (e.g., pubsub tests) Solution: Write the aggregated results_dict to local_benchmark_output_filename and set full_result_path appropriately, so the file preservation logic works. Also removed the None check workaround since it was masking the real issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-client tests were never writing it to the expected output file.