Skip to content

Set specific golangci-lint version on CI check step #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slok merged 2 commits into from
May 23, 2020
Merged

Set specific golangci-lint version on CI check step #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f916692
Set specific golangci-lint version on CI check step
slok May 23, 2020
b0c7dfc
Remove verbosity on tests
slok May 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 4 additions & 16 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,11 @@ jobs:
check:
name: Check
runs-on: ubuntu-latest
# Execute the checks inside the contianer instead the VM.
container: golangci/golangci-lint:v1.27.0-alpine
steps:
- uses: actions/setup-go@v1
with:
go-version: 1.13
- name: Get golangci
run: |
# Add go binaries to GOPATH.
# FIX: https://github.com/actions/setup-go/issues/14
export PATH=${PATH}:`go env GOPATH`/bin
go get -u github.com/golangci/golangci-lint/...
- uses: actions/checkout@v1
- name: check
run: |
# Add go binaries to GOPATH.
# FIX: https://github.com/actions/setup-go/issues/14
export PATH=${PATH}:`go env GOPATH`/bin
make check
- run: golangci-lint run -E goimports

test:
name: Test
Expand All @@ -31,5 +19,5 @@ jobs:
- uses: actions/checkout@v1
- uses: actions/setup-go@v1
with:
go-version: 1.13
go-version: 1.14
- run: make test
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

UNIT_TEST_CMD := go test `go list ./... | grep -v vendor` -race -v
INTEGRATION_TEST_CMD := go test `go list ./... | grep -v vendor` -race -v -tags='integration'
UNIT_TEST_CMD := go test `go list ./... | grep -v vendor` -race
INTEGRATION_TEST_CMD := go test `go list ./... | grep -v vendor` -race -tags='integration'
BENCHMARK_CMD := go test `go list ./... | grep -v vendor` -benchmem -bench=.
CHECK_CMD = golangci-lint run -E goimports
DEPS_CMD := go mod tidy
Expand Down