Skip to content

Conversation

@Joe7M
Copy link
Contributor

@Joe7M Joe7M commented Sep 4, 2023

Hi Chris,

I found the following bug with RTRIM:

s1 = "   test   "
s2 = rtrim(s1)
print "<" + s1 + ">"      ' Output: <   test>
print "<" + s2 + ">"      ' Output: <   test>

Expected output would be, that the input string s1 stays as it is. Instead it got also right trimed.

Copy link
Contributor

@chrisws chrisws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Joerg,

Sorry I just noticed this. Could you please add your code sample as a unit test? This should ensure no future regressions.

Cheers,
Chris

@Joe7M
Copy link
Contributor Author

Joe7M commented Oct 30, 2023

Hi Chris,

I added an unit test for RTRIM.

Best regards, Joerg

Copy link
Contributor

@chrisws chrisws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@chrisws chrisws merged commit 14fc195 into smallbasic:master Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants