-
-
Notifications
You must be signed in to change notification settings - Fork 16
feat: merge upstream scratch-gui updates #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Remove duplicate 'no-warning-comments' rule in src/.eslintrc.js - Use commonHtmlWebpackPluginOptions in webpack.config.js HtmlWebpackPlugin instances 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove duplicate mock file causing Jest warnings - Add missing urlFor method to SeleniumHelper class - Fix 'urlFor is not a function' errors in Ruby tab tests 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🔧 CI Test Fixes AppliedThis update resolves the integration test failures that were blocking the CI: Issues Fixed:
Changes Made:
Test Status:
The integration tests should now pass in the CI environment! 🎉 🤖 Generated with Claude Code |
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add main branch to push triggers for compatibility - Fix deprecated set-output syntax to use $GITHUB_OUTPUT - Correct GitHub expression syntax for hotfix branch detection - Standardize test result file naming (.xml extension) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🔧 CI/CD Workflow ImprovementsUpdated the CI/CD workflow configuration for better maintainability and compatibility: Changes Made:
Technical Details:
These improvements ensure the workflow follows GitHub Actions best practices and maintains compatibility with both legacy and modern branch naming conventions. 🤖 Generated with Claude Code |
- Replace file-based mocks with inline Jest mocks to avoid module name conflicts - Update themes.test.js and monitor.test.jsx to use proper inline mock definitions - Remove physical __mocks__ directories that were causing Jest duplication warnings - Ensure tests use expected mock values instead of actual theme values Fixes unit tests that were failing due to mock configuration issues after upstream merge integration. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🔧 Unit Test Mock Issues FixedResolved the unit test failures that were occurring due to theme mocking conflicts: Problem Analysis:
Solution Applied:
Tests Fixed:
Technical Details:Before (file-based mocks): After (inline mocks): jest.mock('../../../src/lib/themes/dark', () => ({
blockColors: { motion: { primary: '#AAAAAA' }, ... }
}));The unit test failures have been resolved and should now pass in CI! 🎉 🤖 Generated with Claude Code |
…-gui feat: merge upstream scratch-gui updates
…-gui feat: merge upstream scratch-gui updates
…-gui feat: merge upstream scratch-gui updates
Summary
This PR merges the latest upstream changes from MIT's scratch-gui into smalruby3-gui, bringing important bug fixes, new features, and improvements.
Key Changes
🐛 Bug Fixes & Improvements
🎨 UI/UX Enhancements
🔧 Development & Infrastructure
📁 New Components
debug-modal: Interactive debugging assistance with tips and strategiesdelete-confirmation-prompt: Better user confirmation for destructive actionsFiles Changed
.github/workflows/ci-cd.yml,.github/workflows/commitlint.ymlTesting
Compatibility
This merge maintains compatibility with existing Smalruby 3 functionality while incorporating beneficial upstream improvements.
🤖 Generated with Claude Code