Skip to content

Conversation

@smarie
Copy link
Owner

@smarie smarie commented Jun 24, 2020

Will fix #90

@smarie smarie added the enhancement New feature or request label Jun 24, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2020

Codecov Report

Merging #103 into master will increase coverage by 0.56%.
The diff coverage is 89.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   88.70%   89.26%   +0.56%     
==========================================
  Files          79       97      +18     
  Lines        3177     4088     +911     
==========================================
+ Hits         2818     3649     +831     
- Misses        359      439      +80     
Impacted Files Coverage Δ
...s/legacy/advanced/test_suite_parametrized_cases.py 93.75% <ø> (ø)
...es/legacy/advanced/test_suite_shared_dict_cases.py 100.00% <ø> (ø)
pytest_cases/tests/cases/legacy/example_code.py 69.56% <ø> (ø)
...ests/cases/legacy/intermediate/test_two_modules.py 100.00% <ø> (ø)
pytest_cases/tests/cases/legacy/simple/test_so.py 93.75% <ø> (ø)
pytest_cases/tests/cases/legacy/simple/test_so2.py 90.90% <ø> (ø)
pytest_cases/tests/cases/legacy/utils.py 100.00% <ø> (ø)
...test_extension/parametrize_plus/test_lazy_value.py 90.00% <ø> (ø)
pytest_cases/tests/cases/doc/cases_doc.py 73.68% <73.68%> (ø)
pytest_cases/case_funcs_legacy.py 82.35% <75.00%> (ø)
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa37a71...9466f55. Read the comment docs.

Sylvain MARIE added 26 commits June 24, 2020 18:52
…e provided (it was only the case when a `fixture_ref` was present in the argvalues, now it is always the case). Fixes #105
…trize` for `parametrize_plus` (both aliases will coexist with the old names). Fixes #107
…when the new style is used. New submodule `common_others`.
… removed as it was too redundant with the other tags.

`CaseInfo` now replaces all previous structures that were used to store the id, marks, tags on a case.
…`@cases_generator` anymore. Fixes #106 (second half of it)
 - lazy values -related stuff is now in a dedicated file
 - lazy tuple items now have a correct id generated even in old pytest 2
 - all mark-related utils are in a dedicated file. Fixed a with issues with marks related with pytest 2 (make_marked_parameter_value, etc.)
 - new parametrization style in `@parametrize`: cartesian product of argnames, argvalues is now correct even when custom marks and lazy values are present
Sylvain MARIE added 8 commits July 7, 2020 18:21
… which handles correctly `lazy_value` in particular
…custom `prefix` (default `case_`) and `filter` supporting a glob-like string in addition to a callable. Fixes #108
…llables now receive the case function. Also, the case info located at `c._pytestcase` is now always present, with an id even if all the defaults are used.

`get_pytest_parametrize_args` renamed `get_parametrize_args` now that returned arguments are all lazy values or fixture refs and therefore can't work with pytest parametrize.
@smarie smarie merged commit a708fbe into master Jul 9, 2020
@smarie smarie deleted the towards_v2 branch July 9, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

V2: Align case functions with parametrize_plus/fixture_ref experience

3 participants