-
Notifications
You must be signed in to change notification settings - Fork 40
[WIP] Towards v2 #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[WIP] Towards v2 #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 88.70% 89.26% +0.56%
==========================================
Files 79 97 +18
Lines 3177 4088 +911
==========================================
+ Hits 2818 3649 +831
- Misses 359 439 +80
Continue to review full report at Codecov.
|
…urns a non-subcriptable or too small item
…a class. Added corresponding tests
…e provided (it was only the case when a `fixture_ref` was present in the argvalues, now it is always the case). Fixes #105
…gvalues and ids. Fixes #106
…trize` for `parametrize_plus` (both aliases will coexist with the old names). Fixes #107
…in the argvalues.
…when the new style is used. New submodule `common_others`.
… removed as it was too redundant with the other tags. `CaseInfo` now replaces all previous structures that were used to store the id, marks, tags on a case.
…`@cases_generator` anymore. Fixes #106 (second half of it)
- lazy values -related stuff is now in a dedicated file - lazy tuple items now have a correct id generated even in old pytest 2 - all mark-related utils are in a dedicated file. Fixed a with issues with marks related with pytest 2 (make_marked_parameter_value, etc.) - new parametrization style in `@parametrize`: cartesian product of argnames, argvalues is now correct even when custom marks and lazy values are present
…ion (**args AND argnames/argvalues)
…ransformed into fixtures and injected as `fixture_ref`.
…aught and hidden anymore but is emitted to the user.
… which handles correctly `lazy_value` in particular
…custom `prefix` (default `case_`) and `filter` supporting a glob-like string in addition to a callable. Fixes #108
…llables now receive the case function. Also, the case info located at `c._pytestcase` is now always present, with an id even if all the defaults are used. `get_pytest_parametrize_args` renamed `get_parametrize_args` now that returned arguments are all lazy values or fixture refs and therefore can't work with pytest parametrize.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix #90