wrong implementation in datamodels_subject(subject: str), inconsistant with the structure of official_list_data_models.json

[agaldemas]

in the function datamodels_subject(subject: str) in pysmartdatamodels.py, the code can't work !
in

for item in datamodelsdict:
            if "repoName" and "dataModels" in item:
                if item["repoName"] == subject:
                    output = item["dataModels"]
                    done = True

but the structure of official_list_data_models.json is

"officialList": [
    {
      "repoName": "dataModel.User",
      "repoLink": "https://github.com/smart-data-models/dataModel.User.git",
      "dataModels": [
        "Activity",
        "UserContext"
      ],
      "domains": [
        "CrossSector"
      ]
    },

so the test if item["repoName"] == subject: cannot work !!!!
it should be something like: if subject in item["domains"]: to work !

[agaldemas]

here is the fix for the function in pysmardatamodels.py

# 5
def datamodels_subject(subject: str):
    """List the names of the data models defined in the subject.
    Parameters:
        subject: name of the subject

    Returns:
        if subject is found
            array of strings: data models' names belonging to the subject
        if subject is not found
            False
    """

    output = []
    done = False

    with open(official_list_file_name, "r", encoding='utf-8') as list_of_datamodels_pointer:
        datamodelsdict = json.load(list_of_datamodels_pointer)["officialList"]
        for item in datamodelsdict:
            if "repoName" and "dataModels" in item:
                if subject in item["domains"]: # change to match the structure of the source
                    output = item["dataModels"]
                    done = True
    if not done:
        output = False

    return output

[albertoabellagarcia]

you are mixing subject with domains. One data model can only belong to one subject (repoName) but to several domains. Sorry to say that this fix is not fix at all.