knowledge extractor #79
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tried to implement different situations: - user query to agent - agent response - commands in system_mode
What done: - agent chat - system commands logs - bash commands logs(but it doesnt work)
krinkin
requested changes
Mar 25, 2025
Contributor
krinkin
left a comment
krinkin
left a comment
There was a problem hiding this comment.
consider to refactor logging (add logger for the whole project)
|
|
||
| class SessionTracker { | ||
| public: | ||
| enum class EventType { |
|
|
||
| void openLogFile(); | ||
|
|
||
| sqlite3 *db; |
Contributor
There was a problem hiding this comment.
It is better to use some prefix for members
tui-tux/src/session_tracker.cpp
Outdated
| // interactions -- table for user chat with agent | ||
| // commands -- bash commands | ||
| // system_commands -- commands in system mode | ||
| const char *schemaSql = R"SQL( |
tui-tux/src/session_tracker.cpp
Outdated
| resolved BOOLEAN DEFAULT 0, | ||
| FOREIGN KEY(session_id) REFERENCES sessions(session_id) | ||
| ); | ||
| CREATE TABLE IF NOT EXISTS commands ( |
Contributor
There was a problem hiding this comment.
Think on joining this two tables
| int handle_input(); | ||
|
|
||
| static void handle_pty_input(int fd, char ch); | ||
| void handle_pty_input(int fd, char ch); |
tui-tux/src/command_manager.cpp
Outdated
| const std::pair<std::string, std::string> bookmark = bookmark_manager->get_bookmark(alias); | ||
| bookmark_manager->agency_manager->session_history.push_back(bookmark); | ||
| std::cout << bookmark.second << "\n"; | ||
| SessionTracker::get().finalizeCommand(0, "Alias executed: " + alias); |
Contributor
There was a problem hiding this comment.
Consider to define names and values for different error codes
tui-tux/src/terminal_multiplexer.cpp
Outdated
|
|
||
| void TerminalMultiplexer::handle_pty_input(const int fd, const char ch) { | ||
| if (ch == '\n') { | ||
| SessionTracker::get().logEvent(SessionTracker::EventType::ShellCommand, current_command); |
Contributor
There was a problem hiding this comment.
it should be a separated method like update_command
… full support of logging command and its output
korotn3v
commented
Apr 10, 2025
| void resize(); | ||
| void run_terminal(); | ||
| int handle_screen_output(Screen &screen, int fd) const; | ||
| int handle_screen_output(Screen &screen, int fd); |
Author
There was a problem hiding this comment.
I've done it because i want to call non-const method to collect command output and change variable last_command_finished
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Knowledge Extractor component
This component add to ishell functionality to capture user actions, save them into session history, ability to create structured markdown protocols from this history and group them by tags. And ability to reuse this knowledges in the future by adding them to AI's context at the problem solving.
Session capturing
A singleton class, SessionTracker, has been created to handle logging into an SQLite database. It is responsible for recording:
Persistant storage
sessions,commands,interactions,bookmarksandknowledge baseUsage of knowledge base
markdowncomand to operate with knowladges in system mode