Skip to content

Conversation

@rsimari
Copy link
Contributor

@rsimari rsimari commented Oct 23, 2025

No description provided.

@linear
Copy link

linear bot commented Oct 23, 2025

@rsimari rsimari requested a review from Copilot October 24, 2025 13:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes deprecated fields and standardizes property names across the API schema to improve type safety and API consistency. The changes focus on simplifying the signal structure by removing unnecessary fields like id, type, and links, while making certain fields required and standardizing unit names.

Key changes:

  • Removed id, type, and links fields from signal schemas, replacing with code, name, and group as primary identifiers
  • Standardized unit names (e.g., "kilometers" → "km", "degrees-celsius" → "celsius", "kilowatt-hours" → "kWh")
  • Added explicit required field constraints across multiple schemas to improve type safety

Reviewed Changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
signal-open-api.yml Updated SignalBase schema to remove deprecated fields, standardized unit enums, added required fields to SignalError, removed enum constraints from connector types
schema.yml Removed server configuration, updated example UUIDs, expanded WebhookVehicleStateEvent with explicit type definitions, renamed recordedAt to oemUpdatedAt, removed ObjectValue schema
packages/signals/src/test/types.test.ts Removed assertions for deprecated id, type, and links fields, added optional chaining for status checks, removed tests for links structure and ID uniqueness
packages/signals/src/test/parse.test.ts Removed assertion checking the id field of parsed signals
packages/signals/src/test/integration.test.ts Added optional chaining for status field access, removed assertion for error description field
packages/signals/src/test/fixtures/mock-signals.ts Updated mock data to remove id, type, and links fields, added name and group fields to all mock signals

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rsimari rsimari requested a review from wystans October 24, 2025 13:24
@rsimari rsimari marked this pull request as ready for review October 24, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants