-
Notifications
You must be signed in to change notification settings - Fork 22
Separate tests, fix linting, and utilize CI #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| // Flat config for ESLint v9+ | ||
| import tseslint from '@typescript-eslint/eslint-plugin' | ||
| import tsParser from '@typescript-eslint/parser' | ||
| import prettier from 'eslint-plugin-prettier' | ||
|
|
||
| export default [ | ||
| { | ||
| ignores: ['dist/**', 'node_modules/**', 'coverage/**', 'artifacts/**', 'artifacts-compile/**', 'cache/**'], | ||
| }, | ||
| { | ||
| files: ['src/**/*.{ts,js}', 'test/**/*.{ts,js}'], | ||
| languageOptions: { | ||
| parser: tsParser, | ||
| ecmaVersion: 2022, | ||
| sourceType: 'module', | ||
| globals: { | ||
| node: true, | ||
| es2022: true, | ||
| browser: true, | ||
| }, | ||
| }, | ||
| plugins: { | ||
| '@typescript-eslint': tseslint, | ||
| prettier, | ||
| }, | ||
| rules: { | ||
| ...tseslint.configs.recommended.rules, | ||
| 'prettier/prettier': 'error', | ||
| '@typescript-eslint/no-explicit-any': 'off', | ||
| '@typescript-eslint/ban-ts-comment': 'off', | ||
| '@typescript-eslint/no-non-null-assertion': 'off', | ||
| '@typescript-eslint/no-unused-vars': [ | ||
| 'error', | ||
| { | ||
| argsIgnorePattern: '^_', | ||
| varsIgnorePattern: '^_', | ||
| ignoreRestSiblings: true, | ||
| }, | ||
| ], | ||
| '@typescript-eslint/explicit-module-boundary-types': 'off', | ||
| }, | ||
| }, | ||
| { | ||
| files: ['test/**/*.{ts,js}'], | ||
| rules: { | ||
| '@typescript-eslint/no-unused-vars': 'off', | ||
| }, | ||
| }, | ||
| ] | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| import { forkClient, testClient } from "./clients"; | ||
| import { forkClient, testClient } from './clients' | ||
|
|
||
| export const mineBlock = async (isFork: boolean) => { | ||
| const client = isFork? forkClient : testClient; | ||
| await client.mine({ | ||
| blocks: 1 | ||
| }) | ||
| }; | ||
| const client = isFork ? forkClient : testClient | ||
| await client.mine({ | ||
| blocks: 1, | ||
| }) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,117 @@ | ||
| import { expect, it, beforeAll, describe } from '@jest/globals' | ||
| import * as CCIP from '../src/api' | ||
| import * as Viem from 'viem' | ||
| import { hederaTestnet } from 'viem/chains' | ||
| import bridgeToken from '../artifacts-compile/BridgeToken.json' | ||
|
|
||
| const ccipClient = CCIP.createClient() | ||
| const bridgeTokenAbi = bridgeToken.contracts['src/contracts/BridgeToken.sol:BridgeToken'].bridgeTokenAbi | ||
|
|
||
| const HEDERA_TESTNET_RPC_URL = process.env.HEDERA_TESTNET_RPC_URL || 'https://testnet.hashio.io/api' | ||
| const SEPOLIA_CHAIN_SELECTOR = '16015286601757825753' | ||
|
|
||
| describe('Integration (viem): Hedera -> Sepolia', () => { | ||
| let hederaTestnetClient: Viem.Client | ||
| let bnmToken_hedera: any | ||
|
|
||
| const HEDERA_TESTNET_CCIP_ROUTER_ADDRESS = '0x802C5F84eAD128Ff36fD6a3f8a418e339f467Ce4' | ||
| const LINK_TOKEN_HEDERA = '0x90a386d59b9A6a4795a011e8f032Fc21ED6FEFb6' | ||
| const WRAPPED_HBAR = '0xb1F616b8134F602c3Bb465fB5b5e6565cCAd37Ed' | ||
|
|
||
| beforeAll(async () => { | ||
| hederaTestnetClient = Viem.createPublicClient({ | ||
| chain: hederaTestnet, | ||
| transport: Viem.http(HEDERA_TESTNET_RPC_URL, { fetchOptions: { keepalive: false } }), | ||
| }) | ||
|
|
||
| bnmToken_hedera = Viem.getContract({ | ||
| address: '0x01Ac06943d2B8327a7845235Ef034741eC1Da352', | ||
| abi: bridgeTokenAbi, | ||
| client: hederaTestnetClient, | ||
| }) | ||
|
|
||
| expect(bnmToken_hedera.address).toEqual('0x01Ac06943d2B8327a7845235Ef034741eC1Da352') | ||
| }) | ||
|
|
||
| it('returns on-ramp address', async function () { | ||
| const hederaOnRampAddress = await ccipClient.getOnRampAddress({ | ||
| client: hederaTestnetClient, | ||
| routerAddress: HEDERA_TESTNET_CCIP_ROUTER_ADDRESS, | ||
| destinationChainSelector: SEPOLIA_CHAIN_SELECTOR, | ||
| }) | ||
| expect(hederaOnRampAddress).toBeDefined() | ||
| }) | ||
|
|
||
| it('lists supported fee tokens', async function () { | ||
| const result = await ccipClient.getSupportedFeeTokens({ | ||
| client: hederaTestnetClient, | ||
| routerAddress: HEDERA_TESTNET_CCIP_ROUTER_ADDRESS, | ||
| destinationChainSelector: SEPOLIA_CHAIN_SELECTOR, | ||
| }) | ||
| expect(result.length).toBeGreaterThan(0) | ||
| expect(result).toEqual(expect.arrayContaining([LINK_TOKEN_HEDERA, WRAPPED_HBAR])) | ||
| }) | ||
|
|
||
| it('fetched lane rate refill limits are defined', async function () { | ||
| const { tokens, lastUpdated, isEnabled, capacity, rate } = await ccipClient.getLaneRateRefillLimits({ | ||
| client: hederaTestnetClient, | ||
| routerAddress: HEDERA_TESTNET_CCIP_ROUTER_ADDRESS, | ||
| destinationChainSelector: SEPOLIA_CHAIN_SELECTOR, | ||
| }) | ||
|
|
||
| expect(typeof tokens).toBe('bigint') | ||
| expect(typeof lastUpdated).toBe('number') | ||
| expect(typeof isEnabled).toBe('boolean') | ||
| expect(typeof capacity).toBe('bigint') | ||
| expect(typeof rate).toBe('bigint') | ||
| }) | ||
|
|
||
| it('returns token rate limit by lane', async function () { | ||
| const { tokens, lastUpdated, isEnabled, capacity, rate } = await ccipClient.getTokenRateLimitByLane({ | ||
| client: hederaTestnetClient, | ||
| routerAddress: HEDERA_TESTNET_CCIP_ROUTER_ADDRESS, | ||
| supportedTokenAddress: bnmToken_hedera.address, | ||
| destinationChainSelector: SEPOLIA_CHAIN_SELECTOR, | ||
| }) | ||
|
|
||
| expect(typeof tokens).toBe('bigint') | ||
| expect(typeof lastUpdated).toBe('number') | ||
| expect(typeof isEnabled).toBe('boolean') | ||
| expect(typeof capacity).toBe('bigint') | ||
| expect(typeof rate).toBe('bigint') | ||
| }) | ||
|
|
||
| it('getFee is not supported on Hedera Router (throws)', async function () { | ||
| await expect(async () => | ||
| ccipClient.getFee({ | ||
| client: hederaTestnetClient, | ||
| routerAddress: HEDERA_TESTNET_CCIP_ROUTER_ADDRESS, | ||
| tokenAddress: bnmToken_hedera.address, | ||
| amount: Viem.parseEther('0.00000001'), | ||
| destinationChainSelector: SEPOLIA_CHAIN_SELECTOR, | ||
| destinationAccount: '0x0000000000000000000000000000000000000001', | ||
| }), | ||
| ).rejects.toThrow() | ||
| }) | ||
|
|
||
| it('returns token admin registry', async function () { | ||
| const result = await ccipClient.getTokenAdminRegistry({ | ||
| client: hederaTestnetClient, | ||
| routerAddress: HEDERA_TESTNET_CCIP_ROUTER_ADDRESS, | ||
| tokenAddress: bnmToken_hedera.address, | ||
| destinationChainSelector: SEPOLIA_CHAIN_SELECTOR, | ||
| }) | ||
|
|
||
| expect(result).toBeDefined() | ||
| }) | ||
|
|
||
| it('checks if BnM token is supported for transfer', async function () { | ||
| const result = await ccipClient.isTokenSupported({ | ||
| client: hederaTestnetClient, | ||
| routerAddress: HEDERA_TESTNET_CCIP_ROUTER_ADDRESS, | ||
| tokenAddress: bnmToken_hedera.address, | ||
| destinationChainSelector: SEPOLIA_CHAIN_SELECTOR, | ||
| }) | ||
| expect(typeof result).toBe('boolean') | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--forceExit is generally not recommended. If its the best way for now then perhaps update the comment I left in integration test file, line 22 or so that is marked with a TODO? just to explain the context?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the comment to explain. I gave it a quick shot keep the tests from hanging without forceExit and wasn't successful. So probably best for that to be a chore for later.