Prep release 1.6.3 #1261
Prep release 1.6.3 #1261
Conversation
| "@chainlink/contracts-ccip": patch | ||
| --- | ||
|
|
||
| Rate limits are now applied on the dest denomination for releaseOrMint calls |
There was a problem hiding this comment.
Old changesets should have been consumed long ago. Removing them now
RensR
force-pushed
the
prep-rlease
branch
2 times, most recently
from
9dbfd86 to
a60edd2
Compare
| _assertFeeQuoterStaticConfigsEqual(s_feeQuoter.getStaticConfig(), staticConfig); | ||
| assertEq(feeTokens, s_feeQuoter.getFeeTokens()); | ||
| assertEq(priceUpdaters, s_feeQuoter.getAllAuthorizedCallers()); | ||
| assertEq(s_feeQuoter.typeAndVersion(), "FeeQuoter 1.6.3-dev"); |
There was a problem hiding this comment.
huh! I'm surprised this didn't fail the test coverage check, I recall we were 1 line away from failing, did something change there
There was a problem hiding this comment.
I think it doens't count constant strings as lines of code to be tested. I really dislike these types of assertions (constant == constant) as they only cause churn during updates.
|
since we are at it, shall we include abi versioning as well i.e. from to |
| // Determine the base output path - flatten to version/filename structure | ||
| relPath, err := filepath.Rel(gobindingsDir, path) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to get relative path: %w", err) |
There was a problem hiding this comment.
| return fmt.Errorf("failed to get relative path: %w", err) | |
| return fmt.Errorf("failed to get relative path for %s: %w", path, err) |
| func processGoFile(path, gobindingsDir, bytecodeDir, abiDir string) error { | ||
| // Extract metadata from the file | ||
| metadata, err := extractMetadata(path) | ||
| if err != nil { |
There was a problem hiding this comment.
nit: feels safer to fail the generation process if there is error here, or metadata.Bytecode == "", or metadata.ABI == "", to ensure there is always valid bin and abi for every contract wrapper, as opposed to failing silently cuz no one checks CI output
|
4 participants
Preps 1.6.3 which only includes the FeeQuoter. It bumps all pools on 1.6.3-dev to 1.6.4-dev.
This PR adds the compiled bytecode from gethwrappers to NPM releases. It copies the bytecode by traversing the AST. This process does not impact any devex as it only happens during package cuts.
PR blocked by the merger of 1.6.3 FeeQuoter #1217