-
Notifications
You must be signed in to change notification settings - Fork 24
add cache settings to http action. introduce gateway types for http t… #1301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jinhoonbang
commented
Jun 26, 2025
- add cache settings to http action
- introduce gateway types for http trigger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds caching settings for HTTP actions and introduces gateway types for HTTP triggers.
- Remove outdated HTTP request/response types in favor of new definitions.
- Add HTTP trigger types for workflow execution via HTTP.
- Update proto definitions and generated code to include cache settings and adjust response structure.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
pkg/types/gateway/types.go | Removed obsolete HTTP action types. |
pkg/types/gateway/trigger.go | Introduced HTTP trigger request/response types. |
pkg/types/gateway/action.go | Added cache settings and updated HTTP action request/response definitions. |
pkg/capabilities/v2/actions/http/client.proto | Updated proto definition to include cache settings; removed error message. |
pkg/capabilities/v2/actions/http/client.pb.go | Regenerated proto bindings to reflect updated proto definitions. |
Comments suppressed due to low confidence (2)
pkg/types/gateway/action.go:24
- Consider renaming the JSON key from 'workflowId' to 'workflowID' for consistency with previous naming conventions and to avoid potential confusion.
WorkflowID string `json:"workflowId"`
pkg/capabilities/v2/actions/http/client.proto:18
- Review the removal of the 'error_message' field in the Response message to ensure that clients relying on error details are not adversely affected by this change.
CacheSettings cache_settings = 6;
} | ||
|
||
message Response { | ||
string error_message = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error_message is being removed because in HTTP error response, the message portion is optional (Not Found
in 404 Not Found
). Workflow authors should rely on status_code
field for HTTP error.