Skip to content

Consensus capability API change to support both mode-switch and report-gen #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2025
Merged

Consensus capability API change to support both mode-switch and report-gen #1320

merged 2 commits into from
Jul 2, 2025

Conversation

bolekk
Copy link
Contributor

@bolekk bolekk commented Jul 1, 2025

No description provided.

@bolekk bolekk marked this pull request as ready for review July 2, 2025 16:30
@bolekk bolekk requested review from a team as code owners July 2, 2025 16:30
@bolekk bolekk requested review from MStreet3 and nolag July 2, 2025 16:31
nolag
nolag reviewed Jul 2, 2025
View reviewed changes
@bolekk bolekk requested a review from a team as a code owner July 2, 2025 18:08
@bolekk bolekk requested a review from chudilka1 July 2, 2025 18:08
@bolekk bolekk enabled auto-merge (squash) July 2, 2025 18:22
nolag
nolag requested changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@nolag nolag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test that will run against the SDKs needs to change. The folder with it's test should too.

https://github.com/smartcontractkit/chainlink-common/blob/main/pkg/workflows/wasm/host/standard_test.go#L111C5-L113C11

https://github.com/smartcontractkit/chainlink-common/blob/main/pkg/workflows/wasm/host/standard_tests/mode_switch/successful_mode_switch/main_wasip1.go#L32

@bolekk bolekk merged commit 07178aa into main Jul 2, 2025
15 of 18 checks passed
@bolekk bolekk deleted the consensus_sdk branch July 2, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nolag nolag nolag approved these changes

@MStreet3 MStreet3 MStreet3 approved these changes

@krehermann krehermann krehermann approved these changes

@chudilka1 chudilka1 Awaiting requested review from chudilka1 chudilka1 is a code owner automatically assigned from smartcontractkit/foundations

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bolekk @nolag @MStreet3 @krehermann