Skip to content

feat(sui): support host port mapping #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2025
Merged

feat(sui): support host port mapping #2044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2358f2
feat(sui): support host port mapping
graham-chainlink Aug 13, 2025
39f30e4
test(ton): use dev image
graham-chainlink Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 22 additions & 7 deletions framework/components/blockchain/sui.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (

"github.com/block-vision/sui-go-sdk/models"
"github.com/docker/docker/api/types/container"
"github.com/docker/go-connections/nat"
"github.com/go-resty/resty/v2"
"github.com/testcontainers/testcontainers-go"
"github.com/testcontainers/testcontainers-go/wait"
Expand Down Expand Up @@ -81,10 +82,9 @@ func defaultSui(in *Input) {
if in.Image == "" {
in.Image = "mysten/sui-tools:devnet"
}
if in.Port != "" {
framework.L.Warn().Msgf("'port' field is set but only default port can be used: %s", DefaultSuiNodePort)
if in.Port == "" {
in.Port = DefaultSuiNodePort
}
in.Port = DefaultSuiNodePort
}

func newSui(in *Input) (*Output, error) {
Expand All @@ -97,7 +97,8 @@ func newSui(in *Input) (*Output, error) {
return nil, err
}

bindPort := fmt.Sprintf("%s/tcp", in.Port)
// Sui container always listens on port 9000 internally
containerPort := fmt.Sprintf("%s/tcp", DefaultSuiNodePort)

// default to amd64, unless otherwise specified
imagePlatform := "linux/amd64"
Expand All @@ -107,15 +108,29 @@ func newSui(in *Input) (*Output, error) {

req := testcontainers.ContainerRequest{
Image: in.Image,
ExposedPorts: []string{in.Port, DefaultFaucetPort},
ExposedPorts: []string{containerPort, DefaultFaucetPort},
Name: containerName,
Labels: framework.DefaultTCLabels(),
Networks: []string{framework.DefaultNetworkName},
NetworkAliases: map[string][]string{
framework.DefaultNetworkName: {containerName},
},
HostConfigModifier: func(h *container.HostConfig) {
h.PortBindings = framework.MapTheSamePort(bindPort, DefaultFaucetPort)
// Map user-provided host port to container's default port (9000)
h.PortBindings = nat.PortMap{
nat.Port(containerPort): []nat.PortBinding{
{
HostIP: "0.0.0.0",
HostPort: in.Port,
},
},
nat.Port(DefaultFaucetPort): []nat.PortBinding{
{
HostIP: "0.0.0.0",
HostPort: DefaultFaucetPortNum,
},
},
}
framework.ResourceLimitsFunc(h, in.ContainerResources)
},
ImagePlatform: imagePlatform,
Expand Down Expand Up @@ -165,7 +180,7 @@ func newSui(in *Input) (*Output, error) {
Nodes: []*Node{
{
ExternalHTTPUrl: fmt.Sprintf("http://%s:%s", host, in.Port),
InternalHTTPUrl: fmt.Sprintf("http://%s:%s", containerName, in.Port),
InternalHTTPUrl: fmt.Sprintf("http://%s:%s", containerName, DefaultSuiNodePort),
},
},
}, nil
Expand Down
2 changes: 1 addition & 1 deletion framework/examples/myproject/smoke_ton.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[blockchain_a]
type = "ton"
image = "ghcr.io/neodix42/mylocalton-docker:latest"
image = "ghcr.io/neodix42/mylocalton-docker:dev"
Copy link
Contributor

@Tofel Tofel Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious: why? also, don't they have a more stable tag?

Copy link
Contributor Author

@graham-chainlink graham-chainlink Aug 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we look https://github.com/neodix42/mylocalton-docker/pkgs/container/mylocalton-docker, i think dev is more stable, last change is 3 months ago, but latest is released few days ago and it is broken.

port = "8000"

[blockchain_a.custom_env]
Expand Down
Loading