Add port option to Sui #2045
Closed
Add port option to Sui #2045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RodrigoAD
force-pushed
the
add-sui-port
branch
from
0f81147 to
28590f6
Compare
Member
Author
|
Duplicate of #2044 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input.Portoption for Sui. Keeps falling back to default port in case of undefinedBelow is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes ensure that the Sui component correctly sets the default node port if one is not specified by the user, and it now explicitly sets the
--fullnode-rpc-portargument when starting the Sui node to enforce the use of the specified port for RPC connections. This improves usability by ensuring the node is accessible on a predictable port and enhances clarity in the node's configuration.What
defaultSuifunction to setin.PorttoDefaultSuiNodePortifin.Portis empty. This makes sure the default port is used when no port is specified.--fullnode-rpc-portflag within.Portvalue to the command used to start the Sui node. This explicitly sets the RPC port, ensuring the node listens on the correct port.