Skip to content

Conversation

@Tofel
Copy link
Contributor

@Tofel Tofel commented Aug 20, 2025


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes improve reliability and functionality around the Docker Compose setup for testing components, specifically focusing on waiting for services to be fully ready before proceeding. Additionally, they adjust how compose files are referenced and manage test execution conditions to better handle the setup and execution of smoke tests.

What

  • framework/components/dockercompose/.changeset/v0.1.8.md
    • Added a changeset note about waiting for the Red Panda Admin API to ensure readiness.
  • framework/components/dockercompose/chip_ingress_set/chip_ingress.go
    • Added a wait condition for Red Panda's Admin API to be up and running, enhancing the startup robustness of dependent services.
  • framework/examples/myproject/smoke_chip.toml
    • Modified the compose file path to use a file:// scheme, standardizing path references for better compatibility.
  • framework/examples/myproject/smoke_chip_ingress_test.go
    • Enabled skipping a smoke test with a note on dependency for fetching Chip Ingress image, ensuring tests don't fail due to unavailable resources.
    • Added a skip condition for a nested test run to avoid conflicts with proto registration, improving test reliability.

@Tofel Tofel marked this pull request as ready for review August 20, 2025 14:35
@Tofel Tofel requested a review from a team as a code owner August 20, 2025 14:35
@Tofel Tofel merged commit 91f6922 into main Aug 21, 2025
80 of 83 checks passed
@Tofel Tofel deleted the CRE-715-better-chip-ingress-ready-wait branch August 21, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants