Skip to content

Conversation

@Tofel
Copy link
Contributor

@Tofel Tofel commented Aug 28, 2025


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes enhance the reliability and functionality of Docker Compose tests and schema registration in a microservices-based framework. Specifically, the addition of retries in schema registration aims to address transient network issues, while the update in Docker Compose tests ensures a more robust and comprehensive testing environment, including changes to environment variable configuration and service checks.

What

  • .github/workflows/framework-dockercompose-tests.yml
    • Added a new GitHub Actions workflow for running Docker Compose tests, including setting up environment variables, AWS credentials, and caching Go modules.
    • This workflow aims to automate testing of Docker Compose setups for the framework, ensuring that changes do not break existing functionality.
  • framework/components/dockercompose/chip_ingress_set/chip_ingress.go
    • Modified the service wait conditions to include a new HTTP status check for the Red Panda Schema Registry, improving the reliability of service startup verification.
    • These changes ensure that dependent services are fully operational before proceeding with tests or deployments, enhancing stability.
  • framework/components/dockercompose/chip_ingress_set/protos.go
    • Introduced retry logic with backoff for registering schema, addressing potential transient network issues or race conditions with the schema registry.
    • The retry mechanism improves the robustness of schema registration processes, particularly in distributed and dynamic testing environments.
  • framework/components/dockercompose/go.mod and go.sum
    • Added github.com/avast/retry-go/v4 as a dependency, enabling the use of retry logic in schema registration.
    • This dependency is crucial for implementing the retry mechanism in schema registration, ensuring higher success rates in unstable network conditions.
  • framework/examples/myproject/smoke_chip_ingress_test.go
    • Updated the test file by removing an unnecessary skip and environment variable setting, streamlining the test execution process.
    • The adjustments make the testing process more efficient and less prone to being skipped unintentionally, ensuring more consistent test coverage.

@Tofel Tofel changed the title Cre 739 retry proto registration [CRE-739] retry proto registration Aug 28, 2025
@Tofel Tofel changed the base branch from main to revert-2036-chore/exclude-files August 28, 2025 10:14
@Tofel Tofel force-pushed the cre-739-retry-proto-registration branch from 13161a6 to d32102b Compare August 28, 2025 10:20
Base automatically changed from revert-2036-chore/exclude-files to main August 28, 2025 10:32
@Tofel Tofel marked this pull request as ready for review August 28, 2025 10:49
@Tofel Tofel requested a review from a team as a code owner August 28, 2025 10:49
skudasov
skudasov previously approved these changes Aug 28, 2025
@Tofel Tofel enabled auto-merge (squash) August 28, 2025 11:04
@skudasov skudasov self-requested a review August 28, 2025 11:07
@Tofel Tofel merged commit 7e4a950 into main Aug 28, 2025
69 checks passed
@Tofel Tofel deleted the cre-739-retry-proto-registration branch August 28, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants