Skip to content

Conversation

@skudasov
Copy link
Contributor

@skudasov skudasov commented Sep 9, 2025


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes improve the flexibility and observability of the blockchain framework. They allow for custom container names for blockchain nodes, enhancing the ability to organize and identify containers easily. Additionally, by introducing on-chain metrics scrape targets in Prometheus configuration, the changes enable more detailed monitoring of blockchain operations.

What

  • framework/.changeset/v0.10.24.md
    • Added release notes for v0.10.24, mentioning the introduction of on-chain metrics scrape targets and the ability to specify custom names for blockchain containers.
  • framework/components/blockchain/blockchain.go
    • Added a new field ContainerName to the Input struct to allow specifying custom container names.
  • framework/components/blockchain/containers.go
    • Modified baseRequest function to use the custom container name from Input if provided.
  • framework/observability/compose/conf/prometheus.yml
    • Added a new scrape configuration for on-chain metrics with a scrape interval of 2 seconds and specified targets, enhancing Prometheus monitoring capabilities.

@skudasov skudasov requested a review from a team as a code owner September 9, 2025 21:07
@github-actions
Copy link

github-actions bot commented Sep 9, 2025

👋 skudasov, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@skudasov skudasov requested a review from kalverra September 9, 2025 21:08
@skudasov skudasov enabled auto-merge (squash) September 9, 2025 21:12
@skudasov skudasov merged commit 5851fb2 into main Sep 9, 2025
69 checks passed
@skudasov skudasov deleted the add-custom-on-chain-target-prom branch September 9, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants