Skip to content

update prom suffixes #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 18, 2025
Merged

update prom suffixes #2149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed018fc
update prom suffixes
skudasov Sep 18, 2025
7d39392
ignore if there is no compose dir on restart
skudasov Sep 18, 2025
599dac4
changeset
skudasov Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions framework/.changeset/v0.10.28.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Unify local obs stack metrics for otel Prom between local and production, remove suffixes
8 changes: 3 additions & 5 deletions framework/observability.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,12 +173,10 @@ func ObservabilityUpFull() error {

func ObservabilityDown() error {
L.Info().Msg("Removing local observability stack")
err := RunCommand("bash", "-c", fmt.Sprintf(`
_ = RunCommand("bash", "-c", fmt.Sprintf(`
cd %s && \
docker compose down -v && docker rm -f promtail
`, "compose"))
if err != nil {
return err
}
return RunCommand("bash", "-c", "rm -rf compose/")
_ = RunCommand("bash", "-c", "rm -rf compose/")
return nil
}
3 changes: 3 additions & 0 deletions framework/observability/compose/otel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ exporters:
insecure: true
prometheus:
endpoint: "0.0.0.0:8889"
resource_to_telemetry_conversion:
enabled: true
add_metric_suffixes: false

processors:
transform:
Expand Down
Loading