Skip to content

Conversation

@cedric-cordenier
Copy link
Contributor

@cedric-cordenier cedric-cordenier commented Oct 2, 2025


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes introduce the capability to add custom Docker build arguments when building Docker images for Chainlink nodes and related components. This feature allows for more flexible Docker image configurations, enabling the use of different settings or variables during the image build process without modifying the Dockerfile itself.

What

  • framework/components/clnode/clnode.go
    • Added DockerBuildArgs map[string]string to the NodeInput struct. This allows passing custom build arguments to the Docker build command.
  • framework/components/simple_node_set/node_set.go
    • Passed DockerBuildArgs from NodeSpec to clnode.NewNode function calls to ensure custom Docker build arguments are utilized when creating Chainlink node Docker images.
  • framework/docker.go
    • Modified BuildImageOnce and BuildImage functions to accept buildArgs map[string]string as an additional parameter. This enables the use of custom Docker build arguments.
    • Updated Docker build command construction to dynamically include custom build arguments from the buildArgs parameter. This allows for flexible image configuration during build time, including conditions with or without the CTF_CLNODE_DLV environment variable set.

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

👋 cedric-cordenier, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@cedric-cordenier cedric-cordenier force-pushed the PRIV-200-add-build-args-ctf branch from 815e047 to c34a470 Compare October 3, 2025 14:25
@cedric-cordenier cedric-cordenier force-pushed the PRIV-200-add-build-args-ctf branch from 25ac97b to 6173f43 Compare October 3, 2025 16:50
@cedric-cordenier cedric-cordenier enabled auto-merge (squash) October 3, 2025 16:51
@Tofel Tofel self-requested a review October 3, 2025 16:52
@cedric-cordenier cedric-cordenier merged commit ca3fa05 into main Oct 3, 2025
68 of 70 checks passed
@cedric-cordenier cedric-cordenier deleted the PRIV-200-add-build-args-ctf branch October 3, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants