Skip to content

Conversation

@Tofel
Copy link
Contributor

@Tofel Tofel commented Nov 3, 2025

Why?

  1. I believe that env var should take precedence over TOML.
  2. It allow us to use same TOML configs that would normally build an image with existing images just by providing env vars.

Without this PR TOMLs configs that have docker build ctx/file set will fail, if CTF_CHAINLINK_IMAGE is used.


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes ensure that if a Docker image is provided via environment variables for specific components, the Docker build context and file path are unset. This prevents conflicts and ensures that the provided image takes precedence over building a new one.

What

  • framework/.changeset/v0.11.8.md
    • Added a changeset entry for version 0.11.8 mentioning the update regarding Docker build context and filepath changes when CTF_*_IMAGE environment variables are used.
  • framework/components/jd/jd.go
    • Updated NewWithContext function to unset DockerContext and DockerFilePath if CTF_JD_IMAGE environment variable is set, ensuring the custom image is used without attempting to build a new one.
  • framework/components/simple_node_set/node_set.go
    • In the sharedDBSetup function, updated to unset DockerContext and DockerFilePath for node specifications if CTF_CHAINLINK_IMAGE environment variable is set, aligning with the approach of using the specified image directly.

@Tofel Tofel marked this pull request as ready for review November 3, 2025 14:05
@Tofel Tofel requested a review from a team as a code owner November 3, 2025 14:05
@Tofel Tofel merged commit cd424f5 into main Nov 3, 2025
71 of 73 checks passed
@Tofel Tofel deleted the cre-1250-improve-image-override branch November 3, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants