feat: add catalog create address refs changeset#38
Merged
gustavogama-cll merged 2 commits intomainfrom May 8, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Catalog changeset + operation pair to create AddressRef entries in the Catalog-backed datastore, mirroring the existing “create contract metadata” patterns.
Changes:
- Introduces
CreateAddressRefOpoperation to merge the existing datastore into a new in-memory datastore and add providedAddressRefentries. - Adds
CreateAddressRefChangesetwith precondition validation (non-empty input, datastore present, no duplicates, and no existing entries). - Adds unit tests covering precondition validation and apply behavior (success + partial failure on duplicate add).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
catalog/operations/create_address_ref.go |
New operation to add address refs into a merged in-memory datastore and return the updated datastore. |
catalog/changesets/create_address_ref.go |
New changeset that validates input and executes the new operation, returning a ChangesetOutput with datastore + report. |
catalog/changesets/create_address_ref_test.go |
Tests for VerifyPreconditions and Apply, aligned with existing catalog changeset test patterns. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gustavogama-cll
force-pushed
the
ggama/feat/add-catalog-create-address-refs-changeset
branch
from
0e5b4a0 to
9dedeb5
Compare
ecPablo
approved these changes
May 8, 2026
gustavogama-cll
deleted the
ggama/feat/add-catalog-create-address-refs-changeset
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new changeset and supporting operation for adding address reference entries to the Catalog service.
CLD-2301