EVM read support #10
Merged
EVM read support #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernest-nowacki
commented
Aug 19, 2025
Comment on lines
179
to
199
| let chainSelectorSupport = ""; | ||
| let constructorParams = `private readonly mode: Mode = ${service.name}Capability.DEFAULT_MODE`; | ||
|
|
||
| if (isEvmClient && capOption.labels) { | ||
| const chainSelectorLabel = capOption.labels.ChainSelector as any; | ||
| if ( | ||
| chainSelectorLabel?.kind?.case === "uint64Label" && | ||
| chainSelectorLabel?.kind?.value?.defaults | ||
| ) { | ||
| const defaults = chainSelectorLabel.kind.value.defaults; | ||
| chainSelectorSupport = ` | ||
| /** Available chain selectors */ | ||
| static readonly SUPPORTED_CHAINS = { | ||
| ${Object.entries(defaults) | ||
| .map(([key, value]) => ` "${key}": ${value}n`) | ||
| .join(",\n")} | ||
| } as const;`; | ||
|
|
||
| constructorParams = `private readonly mode: Mode = ${service.name}Capability.DEFAULT_MODE,\n private readonly chainSelector?: bigint`; | ||
| } | ||
| } |
There was a problem hiding this comment.
This sections smells a bit. Looks too tightly coupled with EVM Capability while generator should just work for any chain capability.
Wonder if Go code does extra, not-so-out-of-the-box magic for EVM Capability too?
Comment on lines
+15
to
+23
| const STORAGE_ABI = [ | ||
| { | ||
| inputs: [], | ||
| name: "get", | ||
| outputs: [{ internalType: "uint256", name: "", type: "uint256" }], | ||
| stateMutability: "view", | ||
| type: "function", | ||
| }, | ||
| ] as const; |
There was a problem hiding this comment.
Probably should just import (or double check with CRE CLI / SDK GO how they handle loading).
Fine for initial tests.
fmonper1
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't like the fact that I'm passing chainSelector for every capability now in callCapability but this might be a good lead.