debugging workflows #103
Merged
debugging workflows #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| const totalReserveScaled = (reserveInfo as unknown as ReserveInfo) | ||
| .totalReserve; | ||
| const totalReserveScaled = BigInt(reserveInfo.totalReserve * 1e18); |
There was a problem hiding this comment.
Scale here to 18 decimals instead of in fetchReserveInfo to match the Go workflow
jeffrifwaldsmartcontract
force-pushed
the
jr-feat/PoR
branch
from
c0c9276 to
2d58fc3
Compare
| .result(); | ||
|
|
||
| const txHash = resp.txHash; | ||
| // TODO: Why does the writeReport fail with an "execution reverted" error? |
There was a problem hiding this comment.
@ernest-nowacki I can't tell if the abi function is not correct or if the Go side is doing something tricky here. I can run through this step in Go, but here I always get an "execution reverted" error. How did you generate the writeReportFromUpdateReserves call in abi.ts?
ernest-nowacki
approved these changes
Sep 30, 2025
ernest-nowacki
added a commit
that referenced
this pull request
Sep 30, 2025
* Start moving PoR example to the examples repo * update the PoR workflow * Refactor the code * debugging workflows (#103) * Fix PoR example * Revert format changes * use viem Address --------- Co-authored-by: Jeff Rifwald <jeff.rifwald@smartcontract.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the triggers here pass with cre-cli and match the output of the Go PoR workflow with exception of
updateReserves. I keep getting anexecution revertederror on that step. I need to confirm, but looking at the Go generated code, there is a ReservesProxy, so it might be faking the call.I'll see if I can confirm what is going on the Go side, but the updateReserves call txHash message is always
Write report transaction succeeded at" txHash=0x0000000000000000000000000000000000000000000000000000000000000000, so that might mean I'm missing something.