Skip to content

Simplify trigger interfaces #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2025
Merged

Simplify trigger interfaces #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d01b6b3
Simplify trigger interfaces
nolag Sep 5, 2025
1649468
Fix spacing issue
nolag Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions src/generated-sdk/capabilities/blockchain/evm/v1alpha/client_sdk_gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
} from "@cre/generated/sdk/v1alpha/sdk_pb";
import { callCapability } from "@cre/sdk/utils/capabilities/call-capability";
import { CapabilityError } from "@cre/sdk/utils/capabilities/capability-error";
import { BaseTriggerImpl } from "@cre/sdk/utils/triggers/trigger-interface";
import { type Trigger } from "@cre/sdk/utils/triggers/trigger-interface";
import { type Any, AnySchema } from "@bufbuild/protobuf/wkt";
import { getTypeUrl } from "@cre/sdk/utils/typeurl";
import {
Expand Down Expand Up @@ -463,15 +463,13 @@ export class ClientCapability {
/**
* Trigger implementation for LogTrigger
*/
class ClientLogTrigger extends BaseTriggerImpl<FilterLogTriggerRequestJson, Log, Log> {
class ClientLogTrigger implements Trigger<Log, Log> {
constructor(
mode: Mode,
config: FilterLogTriggerRequestJson,
public readonly mode: Mode,
public readonly config: FilterLogTriggerRequestJson,
private readonly _capabilityId: string,
private readonly _method: string
) {
super(mode, config);
}
) {}

capabilityId(): string {
return this._capabilityId;
Expand All @@ -481,10 +479,6 @@ class ClientLogTrigger extends BaseTriggerImpl<FilterLogTriggerRequestJson, Log,
return this._method;
}

newOutput(): Log {
return create(LogSchema);
}

outputSchema() {
return LogSchema;
}
Expand Down
16 changes: 5 additions & 11 deletions src/generated-sdk/capabilities/internal/actionandtrigger/v1/basic_sdk_gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
} from "@cre/generated/sdk/v1alpha/sdk_pb";
import { callCapability } from "@cre/sdk/utils/capabilities/call-capability";
import { CapabilityError } from "@cre/sdk/utils/capabilities/capability-error";
import { BaseTriggerImpl } from "@cre/sdk/utils/triggers/trigger-interface";
import { type Trigger } from "@cre/sdk/utils/triggers/trigger-interface";
import { type Any, AnySchema } from "@bufbuild/protobuf/wkt";
import { getTypeUrl } from "@cre/sdk/utils/typeurl";
import {
Expand Down Expand Up @@ -83,15 +83,13 @@ export class BasicCapability {
/**
* Trigger implementation for Trigger
*/
class BasicTrigger extends BaseTriggerImpl<ConfigJson, TriggerEvent, TriggerEvent> {
class BasicTrigger implements Trigger<TriggerEvent, TriggerEvent> {
constructor(
mode: Mode,
config: ConfigJson,
public readonly mode: Mode,
public readonly config: ConfigJson,
private readonly _capabilityId: string,
private readonly _method: string
) {
super(mode, config);
}
) {}

capabilityId(): string {
return this._capabilityId;
Expand All @@ -101,10 +99,6 @@ class BasicTrigger extends BaseTriggerImpl<ConfigJson, TriggerEvent, TriggerEven
return this._method;
}

newOutput(): TriggerEvent {
return create(TriggerEventSchema);
}

outputSchema() {
return TriggerEventSchema;
}
Expand Down
16 changes: 5 additions & 11 deletions src/generated-sdk/capabilities/internal/basictrigger/v1/basic_sdk_gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
} from "@cre/generated/sdk/v1alpha/sdk_pb";
import { callCapability } from "@cre/sdk/utils/capabilities/call-capability";
import { CapabilityError } from "@cre/sdk/utils/capabilities/capability-error";
import { BaseTriggerImpl } from "@cre/sdk/utils/triggers/trigger-interface";
import { type Trigger } from "@cre/sdk/utils/triggers/trigger-interface";
import { type Any, AnySchema } from "@bufbuild/protobuf/wkt";
import { getTypeUrl } from "@cre/sdk/utils/typeurl";
import {
Expand Down Expand Up @@ -46,15 +46,13 @@ export class BasicCapability {
/**
* Trigger implementation for Trigger
*/
class BasicTrigger extends BaseTriggerImpl<ConfigJson, Outputs, Outputs> {
class BasicTrigger implements Trigger<Outputs, Outputs> {
constructor(
mode: Mode,
config: ConfigJson,
public readonly mode: Mode,
public readonly config: ConfigJson,
private readonly _capabilityId: string,
private readonly _method: string
) {
super(mode, config);
}
) {}

capabilityId(): string {
return this._capabilityId;
Expand All @@ -64,10 +62,6 @@ class BasicTrigger extends BaseTriggerImpl<ConfigJson, Outputs, Outputs> {
return this._method;
}

newOutput(): Outputs {
return create(OutputsSchema);
}

outputSchema() {
return OutputsSchema;
}
Expand Down
16 changes: 5 additions & 11 deletions src/generated-sdk/capabilities/networking/http/v1alpha/http_sdk_gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
} from "@cre/generated/sdk/v1alpha/sdk_pb";
import { callCapability } from "@cre/sdk/utils/capabilities/call-capability";
import { CapabilityError } from "@cre/sdk/utils/capabilities/capability-error";
import { BaseTriggerImpl } from "@cre/sdk/utils/triggers/trigger-interface";
import { type Trigger } from "@cre/sdk/utils/triggers/trigger-interface";
import { type Any, AnySchema } from "@bufbuild/protobuf/wkt";
import { getTypeUrl } from "@cre/sdk/utils/typeurl";
import {
Expand Down Expand Up @@ -46,15 +46,13 @@ export class HTTPCapability {
/**
* Trigger implementation for Trigger
*/
class HTTPTrigger extends BaseTriggerImpl<ConfigJson, Payload, Payload> {
class HTTPTrigger implements Trigger<Payload, Payload> {
constructor(
mode: Mode,
config: ConfigJson,
public readonly mode: Mode,
public readonly config: ConfigJson,
private readonly _capabilityId: string,
private readonly _method: string
) {
super(mode, config);
}
) {}

capabilityId(): string {
return this._capabilityId;
Expand All @@ -64,10 +62,6 @@ class HTTPTrigger extends BaseTriggerImpl<ConfigJson, Payload, Payload> {
return this._method;
}

newOutput(): Payload {
return create(PayloadSchema);
}

outputSchema() {
return PayloadSchema;
}
Expand Down
64 changes: 5 additions & 59 deletions src/generated-sdk/capabilities/scheduler/cron/v1/cron_sdk_gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
} from "@cre/generated/sdk/v1alpha/sdk_pb";
import { callCapability } from "@cre/sdk/utils/capabilities/call-capability";
import { CapabilityError } from "@cre/sdk/utils/capabilities/capability-error";
import { BaseTriggerImpl } from "@cre/sdk/utils/triggers/trigger-interface";
import { type Trigger } from "@cre/sdk/utils/triggers/trigger-interface";
import { type Any, AnySchema } from "@bufbuild/protobuf/wkt";
import { getTypeUrl } from "@cre/sdk/utils/typeurl";
import {
Expand Down Expand Up @@ -43,22 +43,18 @@ export class CronCapability {
trigger(config: ConfigJson): CronTrigger {
return new CronTrigger(this.mode, config, CronCapability.CAPABILITY_ID, "Trigger");
}

// Method legacyTrigger is mapped to untyped API
}

/**
* Trigger implementation for Trigger
*/
class CronTrigger extends BaseTriggerImpl<ConfigJson, Payload, Payload> {
class CronTrigger implements Trigger<Payload, Payload> {
constructor(
mode: Mode,
config: ConfigJson,
public readonly mode: Mode,
public readonly config: ConfigJson,
private readonly _capabilityId: string,
private readonly _method: string
) {
super(mode, config);
}
) {}

capabilityId(): string {
return this._capabilityId;
Expand All @@ -68,10 +64,6 @@ class CronTrigger extends BaseTriggerImpl<ConfigJson, Payload, Payload> {
return this._method;
}

newOutput(): Payload {
return create(PayloadSchema);
}

outputSchema() {
return PayloadSchema;
}
Expand All @@ -91,50 +83,4 @@ class CronTrigger extends BaseTriggerImpl<ConfigJson, Payload, Payload> {
adapt(rawOutput: Payload): Payload {
return rawOutput;
}
}

/**
* Trigger implementation for LegacyTrigger
*/
class CronLegacyTrigger extends BaseTriggerImpl<ConfigJson, LegacyPayload, LegacyPayload> {
constructor(
mode: Mode,
config: ConfigJson,
private readonly _capabilityId: string,
private readonly _method: string
) {
super(mode, config);
}

capabilityId(): string {
return this._capabilityId;
}

method(): string {
return this._method;
}

newOutput(): LegacyPayload {
return create(LegacyPayloadSchema);
}

outputSchema() {
return LegacyPayloadSchema;
}

configAsAny(): Any {
const configMessage = fromJson(ConfigSchema, this.config);
return create(AnySchema, {
typeUrl: getTypeUrl(ConfigSchema),
value: toBinary(ConfigSchema, configMessage),
});
}

/**
* Transform the raw trigger output - override this method if needed
* Default implementation returns the raw output unchanged
*/
adapt(rawOutput: LegacyPayload): LegacyPayload {
return rawOutput;
}
}
Loading
Loading