Unwrap values and simplify timestamp #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-security-plaid-test
bot
requested a review
from tomasz-ratajczyk-sc
|
👋 nolag, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
fmonper1
approved these changes
Sep 11, 2025
| return cre.runInNodeMode(async (_nodeRuntime: NodeRuntime) => { | ||
| const result = await fn(...args) | ||
| return getAggregatedValue((val as any)[valueType](result), aggregationType) | ||
| return getAggregatedValue((result as any)[valueType](result), aggregationType) |
There was a problem hiding this comment.
Hmm I find it weird that this worked. Result is something we are returning from user function. It can for example be a number (10). Previously we were using val helper and then accessed the right type [valueType]. Currently this syntax doesn't make sense to me 🤔
| const onCronTrigger = (_: Config, runtime: Runtime): void => { | ||
| runtime.logger.log('Hello, Calculator! Workflow triggered.') | ||
| cre.sendResponseValue(cre.utils.val.string('Hello, Calculator!')) | ||
| cre.sendResponseValue(new Value('Hello, Calculator!')) |
There was a problem hiding this comment.
If we move utils out of cre namespace we should figure out how do we expose them to the users.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.