Skip to content

Fix consensus hook #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2025
Merged

Fix consensus hook #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ee1a1b
Fix host bindings
ernest-nowacki Sep 12, 2025
fc82047
Fix consensus hook
ernest-nowacki Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sdk/testhelpers/mock-host-bindings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { Mode } from '@cre/generated/sdk/v1alpha/sdk_pb'
// Mock hostBindings before importing runInNodeMode
export const calls: string[] = []
export const mockHostBindings = {
sendResponse: mock((_response: string) => 0),
sendResponse: mock((_response: Uint8Array) => 0),
switchModes: mock((mode: Mode) => {
calls.push(mode === Mode.NODE ? 'NODE' : mode === Mode.DON ? 'DON' : 'UNSPECIFIED')
}),
Expand Down
3 changes: 2 additions & 1 deletion src/sdk/utils/values/consensus-hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { cre } from '@cre/sdk/cre'
import { Value } from '@cre/sdk/utils/values/value'
import { type ConsenusAggregator, getAggregatedValue } from '@cre/sdk/utils/values/consensus'
import { type SupportedValueTypes } from '@cre/sdk/utils/values/value'
import { type NodeRuntime } from '@cre/sdk/runtime/runtime'
Expand Down Expand Up @@ -38,7 +39,7 @@ export const useConsensus = <
return async (...args: TArgs): Promise<any> => {
return cre.runInNodeMode(async (_nodeRuntime: NodeRuntime) => {
const result = await fn(...args)
return getAggregatedValue((result as any)[valueType](result), aggregationType)
return getAggregatedValue(new Value(result), aggregationType)
})
}
}
Expand Down
Loading