Skip to content

Conversation

nolag
Copy link
Contributor

@nolag nolag commented Sep 16, 2025

No description provided.

Copy link

👋 nolag, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@nolag nolag enabled auto-merge September 16, 2025 15:09
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably shouldn't include this in the repo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is temporary until the npm package is published.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I have no idea why mine is so much smaller. I ran bun build:all. I wonder if there had been a debug build checked in by mistake.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even in npm package I believe javy plugin needs to be included, dist is used by npm a lot to distribute artifacts, not sure what would be the alternative ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, so the dist folder would be published in the npm package but not checked into this repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffrifwaldsmartcontract or @ernest-nowacki, anything blocking this PR? I want to build on it to clean up the runtime more :)

@nolag nolag merged commit 8deb592 into main Sep 16, 2025
6 of 7 checks passed
@nolag nolag deleted the rtinianov_consensus branch September 16, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants