fix: await callCapability in action generator #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffrifwaldsmartcontract
requested review from
ernest-nowacki,
fmonper1 and
nolag
| } | ||
| const capabilityId = BasicCapability.CAPABILITY_ID | ||
|
|
||
| return callCapability({ |
There was a problem hiding this comment.
A possible issue here is returning the .then result in an async function.
ernest-nowacki
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently coming up with an explaination as to why using await vs
.thenmakes everything suddenly work. It could be an issue with throwing errors in the then callback, but I'll try to pin down the actual issue.It looks like this is where calling
callCabability.thenfails for some reason:https://github.com/smartcontractkit/cre-sdk-typescript/blob/main/src/sdk/utils/lazy-promise.ts#L44
I get stuck at
this.factory()and it never progresses. It doesn't throw an error either. I'm still not sure why usingawaitfixes the issue.