Go: Add FeedVersion10 #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds FeedVersion10 support to the Go version of the Chainlink Data Streams SDK. The implementation follows the established pattern for feed versions by providing data structures, schema definitions, and decoding functionality for the new v10 format.
- Introduces v10 data structures with additional fields for tokenized price and multiplier management
- Adds schema definition and decoding capabilities for the v10 format
- Updates the main feed package to include FeedVersion10 in the version enumeration and type constraints
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go/report/v10/data.go | Implements the v10 data structure, schema definition, and decoding functionality |
| go/report/v10/data_test.go | Provides comprehensive test coverage for v10 data serialization and deserialization |
| go/report/report.go | Updates the Data type constraint to include v10.Data |
| go/feed/feed.go | Adds FeedVersion10 to the version enumeration |
| TokenizedPrice *big.Int | ||
| } | ||
|
|
||
| // Schema returns this data version schema |
There was a problem hiding this comment.
The comment is redundant as it duplicates the comment on line 13. Consider removing this duplicate comment or making it more specific to the method context.
Suggested change
| // Schema returns this data version schema |
Collaborator
Author
There was a problem hiding this comment.
Keeping for consistency between earlier schemas (v8 and v9)
brunotm
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds FeedVersion10 to Go version of the Chainlink Data Streams SDK