Add optional weekend into market status #622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👋 mxiao-cll, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
NPM Publishing labels 🏷️🟢 This PR has valid version labels and will cause a |
mxiao-cll
force-pushed
the
m
branch
2 times, most recently
from
d43e9f7 to
df9431c
Compare
dskloetc
reviewed
Nov 12, 2025
dskloetc
approved these changes
Nov 12, 2025
Contributor
|
🚀 Successfully created version bump PR: #623 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In design of https://docs.google.com/document/d/1PVuwVubUOE_o8gJlrLfccU71v2WZKB66TULWMkODXQc/edit?tab=t.0
the weekend hours are hard-coded, I decided to hard code it on the jobSpec.
Here I am adding a new optional weekend input param as well as a validator and utility function to check if it is currently weekend