Skip to content

Conversation

harry-anderson
Copy link
Collaborator

@harry-anderson harry-anderson commented Jun 3, 2025

Description

Add support for OIDC based authentication, log user in on successful redirect from OIDC provider.
This is the front end changes for smartcontractkit/chainlink#14406

image

This PR adds logic to the SignIn page to detect for query params 'code' and 'state' if these params are found, the front end application call the backend to exchange to code for a valid user session. If successful, sign the user in.

Steps to Test

  1. yarn && yarn setup
  2. yarn start
  3. ...etc

Checklist

If this PR creates changes to the operator-ui itself, rather than tests, pipeline changes, etc. Then please create a changeset so that a new release is created, and the changelog is updated. See: https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md#what-is-a-changeset

  • This PR has an accompanying changeset if needed.

@harry-anderson harry-anderson self-assigned this Jun 3, 2025
@harry-anderson harry-anderson force-pushed the oidc branch 2 times, most recently from dc97b21 to ec10b5f Compare June 5, 2025 04:54
@harry-anderson harry-anderson marked this pull request as ready for review June 6, 2025 00:05
@harry-anderson harry-anderson force-pushed the oidc branch 2 times, most recently from f8b45b0 to 4a179cb Compare June 9, 2025 23:08
Copy link
Contributor

@jkongie jkongie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good. Just some minor things to address

@harry-anderson
Copy link
Collaborator Author

Thanks for the review @jkongie I have made the following changes based on your suggestions:

  • remove console.log / error statements
  • fix typo in comment
    Appreciate if you could take another look! Thanks

@harry-anderson harry-anderson requested a review from jkongie June 24, 2025 23:57
@cl-sonarqube-production
Copy link

@jmank88 jmank88 requested a review from eutopian June 30, 2025 19:03
@CL-Andrew CL-Andrew merged commit 371c5cf into main Jun 30, 2025
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants