Decouple JWT and session expiration. #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabarnes
reviewed
Aug 3, 2020
django_session_jwt/test.py
Outdated
| @@ -1,5 +1,7 @@ | |||
| from importlib import import_module | |||
|
|
|||
| from jwt.exceptions import DecodeError | |||
There was a problem hiding this comment.
You're right. I removed the exception handling but not the import. Gone.
cabarnes
approved these changes
Aug 3, 2020
|
Thanks Clif! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a setting to JWT middleware that allows the token expiration to be set independently of the session expiration. The token is renewed if the current time exceeds half of it's lifetime. For example, if a token expires in 8h, it will be refreshed after 4h. The session expiration now solely controls the session lifetime. The token expiration is ONLY to defend against tokens being compromised and remaining valid for eternity.
Closes #8