Use values set for the middleware as defaults #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExceptionNotifier works OK as long as you don't have to manually
call the
Notifier#exception_notificationmethod yourself andrely on the middleware to do your job.
However, if you are using a Rails action to show 500 errors (e.g.
you are using the
rescue_fromhelper in yourApplicationController), then you will have to reconfigure the
ExceptionNotifier options.
This means that in your controller you'd have something like:
... which means code duplication, especially if you have more
than one action that's handling exceptions.
This commit should solve this problem by making the default
attributes writable and use the initial middleware configuration
to set those defaults to something more sensible.