fix: linting error with new version (#156)

Author: buehler

.travis.yml

@@ -4,11 +4,14 @@ stages:
   - name: test
     if: tag IS blank
   - name: deploy
-    if: branch = master
+    if: branch = master AND type != pull_request
 
 notifications:
   email: false
 
+env:
+  - BUILD_LEADER_ID=4
+
 jobs:
   include:
     - stage: test
@@ -19,10 +22,6 @@ jobs:
       node_js: '7'
       after_success:
         - npm install coveralls@^2.11.9 && cat ./coverage/lcov.info | coveralls
-    - stage: deploy
-      node_js: '8'
-      before_script: npm run build
-      script: npm run semantic-release
     - stage: deploy
       node_js: '8'
       script: npm run typedoc
@@ -31,3 +30,8 @@ jobs:
         skip_cleanup: true
         github_token: $GH_TOKEN
         local_dir: ./docs
+    - stage: deploy
+      node_js: '8'
+      before_script: npm run build
+      script: echo "Deploy with semantic release"
+      after_success: npm run semantic-release

README.md

@@ -6,7 +6,7 @@ but not a great piece of musical history! We compose routes for you. giuseppe is
 [Express](http://expressjs.com/) and depends on it. We were tired of writing all the route registrations by ourselves.
 
 [![Build Status](https://travis-ci.org/smartive/giuseppe.svg)](https://travis-ci.org/smartive/giuseppe)
-[![Build status](https://ci.appveyor.com/api/projects/status/7m14ruqjaopwbfn4?svg=true)](https://ci.appveyor.com/project/buehler/giuseppe)
+[![Build Status](https://ci.appveyor.com/api/projects/status/7m14ruqjaopwbfn4?svg=true)](https://ci.appveyor.com/project/buehler/giuseppe)
 [![npm](https://img.shields.io/npm/v/giuseppe.svg?maxAge=3600)](https://www.npmjs.com/package/giuseppe)
 [![Coverage status](https://img.shields.io/coveralls/smartive/giuseppe.svg?maxAge=3600)](https://coveralls.io/github/smartive/giuseppe)
 [![semantic-release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg)](https://github.com/semantic-release/semantic-release)

docs/index.md

@@ -2,12 +2,13 @@
 layout: default
 title: giuseppe - by smartive AG
 ---
-giuseppe [Italian: dʒuˈzɛppe] is a controller routing system for [Express](http://expressjs.com/) using [TypeScript](https://www.typescriptlang.org/) 
-decorators and annotations named after the great Italian componist Giuseppe Verdi. Like Verdi, 
+giuseppe [Italian: dʒuˈzɛppe] is a controller routing system for [Express](http://expressjs.com/) using [TypeScript](https://www.typescriptlang.org/)
+decorators and annotations named after the great Italian componist Giuseppe Verdi. Like Verdi,
 it composes things, but not a great piece of musical history! We compose routes for you. giuseppe is dedicated to
 [Express](http://expressjs.com/) and depends on it. We were tired of writing all the route registrations by ourselves.
 
 [![Build Status](https://travis-ci.org/smartive/giuseppe.svg)](https://travis-ci.org/smartive/giuseppe)
+[![Build Status](https://ci.appveyor.com/api/projects/status/7m14ruqjaopwbfn4?svg=true)](https://ci.appveyor.com/project/buehler/giuseppe)
 [![npm](https://img.shields.io/npm/v/giuseppe.svg?maxAge=3600)](https://www.npmjs.com/package/giuseppe)
 [![Coverage status](https://img.shields.io/coveralls/smartive/giuseppe.svg?maxAge=3600)](https://coveralls.io/github/smartive/giuseppe)
 [![semantic-release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg)](https://github.com/semantic-release/semantic-release)
@@ -27,15 +28,15 @@ To install this package, simply run
 
 [![NPM](https://nodei.co/npm/giuseppe.png?downloads=true&stars=true)](https://nodei.co/npm/giuseppe/)
 
-The suggested method would actually be: use the yeoman generator which we created @ 
+The suggested method would actually be: use the yeoman generator which we created @
 [generator-giuseppe](https://github.com/smartive/generator-giuseppe).
 It installs all dependencies and libraries that you need.
 
 When you use the manual way npm should install all typing dependencies.
 They are listed in the `package.json` with the `@types` prefix.
 
 This package installs the transpiled `*.js` files instead of `*.ts` files, since the compiler tries
-to compile them everytime. The declaration files with the JSDocs are provided aswell so your 
+to compile them everytime. The declaration files with the JSDocs are provided aswell so your
 autocomplete does work as it should.
 
 ## Migrate to new major versions
@@ -83,12 +84,12 @@ import { Controller, Get, Giuseppe } from 'giuseppe';
 
 @Controller()
 class PingPongController {
-    
+
     @Get('ping')
     public ping(): any {
         return {ping: 'pong'};
     }
-    
+
 }
 
 const giusi = new Giuseppe();
@@ -110,22 +111,22 @@ import { Controller, Get, Query } from 'giuseppe';
 
 @Controller()
 export class PingPongController {
-    
+
     @Get('ping')
     public ping(): any {
         return {ping: 'pong'};
     }
-    
+
 }
 
 @Controller('echo')
 export class EchoController {
-    
+
     @Get()
     public ping(@Query('data') data: string): string {
         return 'you gave me: ' + data;
     }
-    
+
 }
 ```
 
@@ -164,7 +165,7 @@ We're happy if you have any contributions! Every participation counts. Feel free
 open pull requests, issues or use any other form of contribution. Maybe we'll
 set up a `CONTRIBUTING.md` file in the future. soon(tm).
 
-If you want to create a plugin for giuseppe, use the other yeoman generator @ 
+If you want to create a plugin for giuseppe, use the other yeoman generator @
 [generator-giuseppe-plugin](https://github.com/smartive/generator-giuseppe-plugin)
 
 [Full list of contributors](https://github.com/smartive/giuseppe/graphs/contributors)

package.json

@@ -50,20 +50,20 @@
     "@types/express": "^4.0.39",
     "@types/glob": "^5.0.33",
     "@types/http-status": "^0.2.30",
-    "@types/node": "^8.0.47",
+    "@types/node": "^8.0.53",
     "express": "^4.16.2",
     "glob": "^7.1.2",
     "http-status": "^1.0.1",
     "reflect-metadata": "^0.1.10",
     "tslib": "^1.8.0"
   },
   "devDependencies": {
-    "@types/jest": "^21.1.5",
+    "@types/jest": "^21.1.8",
     "del-cli": "^1.1.0",
     "jest": "^21.2.1",
-    "ts-jest": "^21.1.4",
+    "ts-jest": "^21.2.3",
     "tslint": "^5.8.0",
-    "tslint-config-airbnb": "^5.3.0",
+    "tslint-config-airbnb": "^5.4.2",
     "tsutils": "^2.12.2",
     "typedoc": "^0.9.0",
     "typescript": "^2.6.1",

src/core/parameters/GiuseppeBaseParameter.ts

@@ -16,7 +16,7 @@ const PRIMITIVE_TYPES: Function[] = [Object, String, Array, Number, Boolean];
 /**
  * Giuseppe base parameter class. Is used for all core parameters (like cookie or body) to generalize
  * some logic.
- * 
+ *
  * @export
  * @abstract
  * @class GiuseppeBaseParameter
@@ -56,9 +56,8 @@ export abstract class GiuseppeBaseParameter implements ParameterDefinition {
                 const ctor = this.type as any;
                 if (rawValue.constructor === ctor) {
                     return rawValue;
-                } else {
-                    return PRIMITIVE_TYPES.indexOf(ctor) !== -1 ? ctor(rawValue) : new ctor(rawValue);
                 }
+                return PRIMITIVE_TYPES.indexOf(ctor) !== -1 ? ctor(rawValue) : new ctor(rawValue);
             };
         }